New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLXModel.evaluate does not use dataset.iter #87

Open

grananqvist opened this issue Jul 3, 2024 · 0 comments

Labels

Member

grananqvist commented Jul 3, 2024 •

edited

Loading

This was a miss in the initial MLX implementation.
Just like how dataset.iter method is used in other models, e.g. https://github.com/apple/pfl-research/blob/develop/pfl/model/pytorch.py#L389, it should also be used for MLXModel: https://github.com/apple/pfl-research/blob/develop/pfl/model/mlx.py#L261

(131046345)

grananqvist added the Beginner issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment