Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S3 Bucket CRUD operation on Account Manager #442

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Add S3 Bucket CRUD operation on Account Manager #442

merged 8 commits into from
Sep 19, 2024

Conversation

itutu-tienday
Copy link
Collaborator

Functions

  • on Account Manager Screen

    • When adding an account ... create user s3 bucket
    • When deleting an account ... delete user s3 bucket

  • Remarks

    • bucket name format ... optinist-{user_id}-{unique_hash}

Testcase

  1. create user → create bucket succeeded
  2. singin → execute workflow → S3 sync succeeded
  3. delete user → delete bucket succeeded

@itutu-tienday itutu-tienday marked this pull request as ready for review September 18, 2024 11:17
@itutu-tienday itutu-tienday linked an issue Sep 18, 2024 that may be closed by this pull request
[Cloud Support] Remote Bucket Operation per Users (CRUD Bucket) #420
Open
7 tasks
@milesAraya
Copy link
Collaborator

milesAraya commented Sep 18, 2024 •
edited
Loading

I was able to

  • create user → create bucket succeeded
  • delete user → delete bucket succeeded

There was an issue with:

  • sign in with newly created user credentials.

@milesAraya
Copy link
Collaborator

There does seem to be a small issue with files that were created before S3 ws linked not being able to be synced to the cloud. For example, I imported the sample data, linked S3, then could not upload this to the cloud.
However, this was not an issue when S3 is initialised from the beginning. Because it is assumed users will either use S3 or not, then this is probably not very important.

@itutu-tienday itutu-tienday merged commit b20114c into feature/cloud/buckets-switching-operation Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesAraya milesAraya milesAraya approved these changes

Assignees

@milesAraya milesAraya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Support] Remote Bucket Operation per Users (CRUD Bucket)
2 participants
@itutu-tienday @milesAraya