Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search component sortorders only enforced upon instantiation of search view, not mutation #10767

Closed
whatisgalen opened this issue Apr 13, 2024 · 1 comment
Closed

Search component sortorders only enforced upon instantiation of search view, not mutation #10767

whatisgalen opened this issue Apr 13, 2024 · 1 comment

Comments

@whatisgalen
Copy link
Member

the SearchComponent model has a sortorder that is only referenced one place. The utility of Arches sortorder is to manage the order in which search components/filters are executed. Post-instantiation, adding and removing various search filters does not enforce sortorder, meaning that the execution order could be contrary to what was intended. The search filter sortorder should be enforced when the search query gets sent to the search_results method in the SearchView.
@whatisgalen whatisgalen changed the title Search component sortorders only enforced upon instantiation of search view Search component sortorders only enforced upon instantiation of search view, not mutation Apr 13, 2024
whatisgalen added a commit that referenced this issue Apr 13, 2024
@whatisgalen
renames JSON.parsed queryString object to queryObj since its an objec…
e7e0ac1 
…t not a string re #10767
whatisgalen added a commit that referenced this issue Apr 13, 2024
@whatisgalen
sorts Query Object by search filter sortorder in doQuery method, re #…
581caa2 
…10767
@whatisgalen whatisgalen mentioned this issue Apr 13, 2024
Closed
6 tasks
whatisgalen added a commit that referenced this issue Apr 13, 2024
@whatisgalen
minor change in related results search filter assuming all hist retur…
6db9330 
…ned re #10767
@whatisgalen
Copy link
Member Author

closing in favor of #10807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
pipeline
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whatisgalen