Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom labels and annotations to Server, repo, application set and application controller #1530

Open
enriqueav99 opened this issue Aug 30, 2024 · 1 comment · May be fixed by #1532

Comments

@enriqueav99
Copy link

Is your feature request related to a problem? Please describe.
Hi! I need a feature that allows the addition of custom labels and annotations to pods deployed by the operator, specifically in the server, repos, application set and application controller components. This is required to enable direct metric scraping within the pod using Vector in my environment.

Describe the solution you'd like
Something like that:

spec:
  server:
    customPodLabels:
      custom: label
      asdf: server
    customPodAnnotations:
      asdf: server
      custom: annotation
  repo:
    customPodLabels:
      custom: label
      asdf: repo
    customPodAnnotations:
      asdf: repo
      custom: annotation
  controller:
    customPodLabels:
      custom: label
      asdf: controller
    customPodAnnotations:
      asdf: controller
      custom: annotation
  applicationSet:
    customPodLabels:
      custom: label
      asdf: applicationSet
    customPodAnnotations:
      asdf: applicationSet
      custom: annotation

Additional context
When I saw that the operator doesn´t support this feature, I found this issue and this PR. Inspired by the code that @AlexanderThaller did in his branch, I started working on my own version, i have a branch tfor testing and I accidentally opened a PR. I want to make another branch with diferent commits for a better review.

@enriqueav99
Copy link
Author

I'm nooby with go and makefiles, sorry for the unnecessary commits 😅
I included all the important changes in the first commit; the others were just to pass the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment