Question about using hook-delete-policy on Argo Workflow resource #16468
Replies: 2 comments 1 reply
-
Running into the same issue. Can we get some answers please? |
Beta Was this translation helpful? Give feedback.
-
There was a similar issue that has been fixed ages ago: The Gitops-engine bundles a health-check for Workflow resources, but maybe it broke again? See https://github.com/argoproj/gitops-engine/blob/master/pkg/health/health_argo.go#L29 The health check assumes the workflow to be in "progressing" state when the |
Beta Was this translation helpful? Give feedback.
-
(Moved from argoproj/argo-workflows#12280 (comment))
Hi all,
We were looking at hook deletion policy, (which mentioned it could be applied to Workflow resources) and tried to add the following annotations to the Workflow resource:
However, we observed that after the Workflow resource was created and synced, it was deleted before the workflow itself actually completed. There were still pods (for workflow steps) running. As a result, the workflow execution was interrupted (the pods for workflow steps were deleted along with the workflow resource itself) and most of the workflow steps were never run.
Is this the expected behavior? or adding hook delete policy to Workflow resource is not a valid use case in the first place?
Any feedback is appreciated!
Beta Was this translation helpful? Give feedback.
All reactions