Notifications: slack.token does not work, slack-token does. Why?

[thiagowfx]

I am using the ArgoCD helm chart for deployment.

Relevant snippet of values.yaml:

argo-cd:
  notifications:
    enabled: true

    secret:
      # The secret value is managed by External Secrets.
      create: false
      name: argocd-external-secret

    notifiers:
      service.slack: |
        token: $slack-token

The secret is manually created, via https://external-secrets.io/latest/. It looks like this:

$ kubectl describe secret -n argocd argocd-external-secret
Name:         argocd-external-secret
Namespace:    argocd
Labels:       app.kubernetes.io/part-of=argocd
              argocd.argoproj.io/instance=argocd
              reconcile.external-secrets.io/created-by=<hash>
Annotations:  reconcile.external-secrets.io/data-hash: <hash>

Type:  Opaque

Data
====
dex.github.clientSecret:  40 bytes
slack-token:              54 bytes

I would like to rename the secret key to slack.token for consistency with Github SSO (docs) i.e. $dex.github.clientSecret.

However, when I update both values.yaml and the secret key to slack.token (with a period instead of a dash), I get authentication failures (as seen in the logs of argocd-notification-server).

Why is that?

I also tried with slack\.token (attempt to escape the period) to no avail.

[ChristianCiach]

That currently cannot work, because the notification-engine doesn't allow . as part of the secret reference pattern:

https://github.com/argoproj/notifications-engine/blob/261728a36e8357dfa7c258f7e1c4e3e763711ee1/pkg/api/config.go#L60

Adding the dot to the pattern should be trivial, but this would still be an incomplete solution. It would be better if the notification-engine uses the same parsing logic as the rest of Argo-CD, as reported by this related issue:

• Allow dedicated secrets in argocd-notifications-cm #9958