Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to retrieve a tag value from the AWS Medical Imaging data structure. #6461

Open
2 tasks
LeoReubelt opened this issue Sep 11, 2024 · 8 comments
Open
2 tasks
Assignees
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days. service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@LeoReubelt
Copy link

LeoReubelt commented Sep 11, 2024

Describe the feature

A function that would take a DICOM tag, or series of DICOM tags, and return the value for that tag from the AWS Medical Imaging data structure.

Use Case

I have an existing infrastructure that is driven by DICOM tags. I am building new functionality using AWS Medical Imaging. If I had a function that would allow me to get a value for a tag, from the AWS Medical Imaging data structure, I could integrate my new AWS driven functionality with my existing infrastructure.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

3.577.0

Environment details (OS name and version, etc.)

Mac OS Sonoma 14.6.1.

@LeoReubelt LeoReubelt added feature-request New feature or enhancement. May require GitHub community feedback. needs-triage This issue or PR still needs to be triaged. labels Sep 11, 2024
@zshzbh
Copy link

zshzbh commented Sep 11, 2024

Hey @LeoReubelt ,

Thanks for the feedback! AWS SDK has existing DICOM tags listed here. I'm trying to gather more information here. If I understand it right, you want to get the value of the DICOM tag from a function? For example, DICOMPatientName has patient name information, and you want to retrieve that value through the requested function?

If the example is not what you want, could you please give us an example as well as the sample function signature

Thanks!
Maggie

@zshzbh zshzbh added response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Sep 11, 2024
@zshzbh zshzbh self-assigned this Sep 11, 2024
@LeoReubelt
Copy link
Author

LeoReubelt commented Sep 11, 2024

Thanks for getting back to me @zshzbh.

I want to use the tags defined in the DICOM spec to get a value.

For example (0020,0037) is the tag for ImageOrientationPatient. And to get that value in the AWS data structure, you need to access the following path... metaData.Study.Series[SeriesUID].Instances[InstanceUID].DICOM.ImageOrientationPatient.

So I need a mapping from the DICOM spec tags (Spec) to the AWS path. The AWS data structure is great. But the majority of the DICOM using world that I have dealt with uses DICOM tags as defined by the spec. Without that mapping, I can not use any of the DICOM infrastructure that I have build in the past, or work with any outside customer/colleague.

And it would just be a long process for me to figure it out myself. Also, I am certain, this is a deciding factor for developers thinking of using AWS Medical Imaging.

@zshzbh
Copy link

zshzbh commented Sep 11, 2024

@LeoReubelt ,

Thanks for your input! I have created an internal ticket to the service team , ref V1514369668.

We will let you know if there's any updates!

Thanks!
Maggie

@zshzbh zshzbh added the service-api This issue is due to a problem in a service API, not the SDK implementation. label Sep 11, 2024
@chrisbll971
Copy link

Do you know if retrieving DICOM JSON via the DICOM Web endpoints would work for your requirements?

https://docs.aws.amazon.com/healthimaging/latest/devguide/dicomweb-retrieve-instance-metadata.html

@LeoReubelt
Copy link
Author

Thanks for the question @chrisbll971. No, that does not meet my requirement. I am already using that. I need to be able to get a meta data value from the DICOM tag. (0020,0037) is a tag. ImageOrientationPatient is an attribute name.

@chrisbll971
Copy link

Do you know if you are using the GetImageSetMetadata in the AWS SDK or if you are using the referenced DICOM Web RetrieveInstanceMetadata API that returns DICOM JSON? The referenced DICOM Web RetrieveInstanceMetadata API isn't available in the AWS SDK - only the GetImageSetMetadata API.

The RetrieveInstanceMetadata API will return the metadata in DICOM JSON and will use only the tag values (0020,0037)

@LeoReubelt
Copy link
Author

LeoReubelt commented Sep 14, 2024

Interesting. I am using the SDK. Unfortunately it is too late at this point to go back. Because i have been working on the project for 6 months using the sdk. So a converter is really still what i need. But thanks for the tip. Can you easily find where Amazon has that documented? If so, please put it here.

@chrisbll971
Copy link

chrisbll971 commented Sep 14, 2024

Understood - the values come from the DICOM Standard Dictionary. I have not used Javascript for DICOM specifically, however, many DICOM libraries will have a library called "Dictionary" that will have the lookup values auto-generated from the DICOM Standard Dictionary. Two examples:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days. service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

3 participants