Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define and use a base Exception class for the package #49

Open
KlaasH opened this issue Apr 4, 2018 · 0 comments
Open

Define and use a base Exception class for the package #49

KlaasH opened this issue Apr 4, 2018 · 0 comments

Comments

@KlaasH
Copy link
Contributor

KlaasH commented Apr 4, 2018

There are several places where this raises a custom exception with raise Exception(...), e.g.

raise Exception('Must specify both client_id and client_secret to use authentication')
.

Making users of the package catch Exception is not very nice. Even if we don't need subtypes, we should define a base Exception class for the package so that people can make their exception handling more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant