Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sparkle icon system #1111

Open
uiuxxx opened this issue Sep 19, 2024 · 0 comments
Open

Update sparkle icon system #1111

uiuxxx opened this issue Sep 19, 2024 · 0 comments
Assignees

Comments

@uiuxxx
Copy link
Contributor

uiuxxx commented Sep 19, 2024

The API was recently updated and the orange sparkles are being used for any pool with yield in addition to regular swap fees. This has caused some confusion.

Let's update the sparkles to the following:

Image

I have set up a new PR, where I have:

  • Added new light and dark mode sparkles colors
  • Added new 'Single star' to display pool's with swap fees only.

#1110

Tasks remaining:

  1. Single star icon
    • Assign the new uploaded single star icon StarIcon.tsx to display only when a pool has no other yield beyond swap fees.
    • Use the gray colors already defined in the defaultGrad
  2. Gray sparkles icon
    • This icon with the usual 3 stars should be assigned to any pool with yield in addition to swap fees, but with no staking yield.
  3. Orange sparkles
    • This will now only be used to denote pools with staking incentives (could be BAL or other staking incentives)
  4. Gold sparkles icon
    • Bring back the gold sparkles icon for the BAL / WETH 80/20 pool (it got lost with the recent API update)
@uiuxxx uiuxxx assigned uiuxxx and groninge01 and unassigned uiuxxx Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants