Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.4.0] Let repo rule attributes reference extension apparent names #23407

Closed
bazel-io opened this issue Aug 22, 2024 · 4 comments
Closed

[7.4.0] Let repo rule attributes reference extension apparent names #23407

bazel-io opened this issue Aug 22, 2024 · 4 comments

Comments

@bazel-io
Copy link
Member

Forked from #23369

@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Aug 22, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/TypeCheckedTagTest.java

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/TypeCheckedTagTest.java

cc: @bazelbuild/triage

cc: @fmeum @Wyverald @meteorcloudy

@fmeum
Copy link
Collaborator

fmeum commented Sep 19, 2024

@Wyverald Could you help cherry-pick this? It looks like there are a number of refactoring commits missing (AutoValue -> record, module thread context extraction, ...) but I don't know which ones exactly.

@Wyverald
Copy link
Member

uh, apparently I already did that last week... 😅 #23585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants