Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Fix _validation output group merging #23664

Closed
bazel-io opened this issue Sep 19, 2024 · 1 comment
Closed

[7.4.0] Fix _validation output group merging #23664

bazel-io opened this issue Sep 19, 2024 · 1 comment
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #23589
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Sep 19, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/buildtool/BuildResultPrinter.java

cc: @bazelbuild/triage

@fmeum fmeum mentioned this issue Sep 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
@fmeum
Fix _validation output group merging (#23676)
ef26873 
While
cd72583
made it so that a rule and an aspect can both specify validation
outputs, it accidentally didn't actually merge the `_validation` output
groups.

By adding the missing merge logic and having the `ValidateTarget` aspect
depend on all other aspects, both a rule and an aspect returning a
validation output is now fully supported with
`--experimental_use_validation_aspect`.

Closes #23589.

PiperOrigin-RevId: 675294550
Change-Id: I581417bee223f0b6aedbc0ce71cae75cd6609ef7 
(cherry picked from commit 750f0a1)

Fixes #23664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @iancha1992