Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boolean modifiers #325

Open
tyv opened this issue Jan 13, 2013 · 7 comments
Open

boolean modifiers #325

tyv opened this issue Jan 13, 2013 · 7 comments
Assignees
@tenorok
Labels
TODO

Comments

@tyv
Copy link

tyv commented Jan 13, 2013

Would be cool to use simple modifiers like 'block_current', instead of 'block_state_current' or 'block_current_yes'. Same for elems.
@veged
Copy link
Member

veged commented Jan 17, 2013

First problem is inconsistency in i-bem.js API for set modifiers: delMod('m1') ~~ setMod('m1', ''). So we need some special magic for boolean values in setMod: setMod('m1', true), setMod('m1', false).

@Flackus
Copy link

Flackus commented Feb 7, 2013

Thumbs up for this issue.

@denchistyakov
Copy link

👍

@denchistyakov
Copy link

If you fix this it will be great

@arikon
Copy link
Member

arikon commented Nov 20, 2014

@denchistyakov It is already implemented in bem-core. And this change will break backward compatibility. Are you sure you want it in bem-bl?

@tenorok
Copy link
Contributor

tenorok commented Nov 26, 2014

please

@tenorok
Copy link
Contributor

tenorok commented Jan 11, 2015

What about new method with some name as setBoolMod for save backward compatibility?

@deeonis deeonis added the TODO label Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenorok tenorok

Labels
TODO
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@veged @arikon @tyv @denchistyakov @Flackus @tenorok @deeonis