Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Migrate all tests to Feature and suite based #1022

Closed
Xuanwo opened this issue Nov 11, 2021 · 3 comments
Closed

tests: Migrate all tests to Feature and suite based #1022

Xuanwo opened this issue Nov 11, 2021 · 3 comments
Assignees

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Nov 11, 2021

Background

For now, our tests are using convey to write BDD test. However, they could be much simpler if we write them using github.com/stretchr/testify/suite.

Here is an example: #1020

@Joey2132
Copy link
Contributor

So, actually before I handle issue 975, this issue has to be finished first. Is anyone doing it now? If not, I'd like to do it.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Nov 12, 2021

The issue is free for you to take! However, I think it's better to finish #975 before take on this issue.

@Joey2132
Copy link
Contributor

The issue is free for you to take! However, I think it's better to finish #975 before take on this issue.

OK, I will finish #975 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants