Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geocoding - Encode forgets Identifier type #179

Open
wvdvegte opened this issue Apr 23, 2024 · 1 comment · May be fixed by #180
Open

Geocoding - Encode forgets Identifier type #179

wvdvegte opened this issue Apr 23, 2024 · 1 comment · May be fixed by #180

Comments

@wvdvegte
Copy link

Geo version

0.4.2

Orange version

3.36.2

Expected behavior

When trying to encode coordinates for a city that is not a major city in Europe, a change in the setting for Identifier type is persistent when saving the ows file and opening it again

Actual behavior

Changed settings for Identifier type are changed back to Major city (Europe) when saving the ows file.
Geocoding appears to be one of the numerous widgets that doesn't keep their settings when saving the ows file.

Steps to reproduce the behavior

Open attached ows file, change the Identifier type to Major city (World), save the file and open it again.

Additional info (worksheets, data, screenshots, ...)

Geocoding bug.ows.zip
@janezd
Copy link
Collaborator

janezd commented Apr 23, 2024

Thanks. I could easily reproduce it (thanks for instructions!). The error in the code is easy to see and annoying to fix. :)

@janezd janezd linked a pull request Apr 23, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GeoCoding: Don't override identifier type in set_data janezd/orange3-geo
2 participants
@janezd @wvdvegte