Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate property names #31

Open
Tracked by #1
bitbrain opened this issue Jul 22, 2023 · 1 comment
Open
Tracked by #1

Avoid duplicate property names #31

bitbrain opened this issue Jul 22, 2023 · 1 comment
Labels
🐛 bug Something isn't working
Milestone

Comments

@bitbrain
Copy link
Owner

bitbrain commented Jul 22, 2023

It is currently possible to create scenarios where property names can exist multiple times within an entity, leading to undesired behavior. Any property name should be unique per entity.

  • a parent entity cannot define a property that already exists on a child
  • a child entity cannot define a property that got inherited from a parent
  • an entity should not have the same property twice, meaning renaming one property to an already existing name should not be possible
@bitbrain bitbrain changed the title renaming properties allows for duplicate names Avoid duplicate property names Jul 22, 2023
@bitbrain bitbrain added the 🐛 bug Something isn't working label Jul 22, 2023
@bitbrain bitbrain added this to the 1.0.0 milestone Aug 7, 2023
@FonkinS
Copy link

FonkinS commented Aug 19, 2023

So would the best method be to have a signal in the property resource, that calls its 'owner' category/entity to check if it has another property with that name? And then signal back to the property whether it's valid or not? Although I'm not sure if this kind of two way signalling is the best idea.

@bitbrain bitbrain pinned this issue Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants