Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Pandora singleton access inside the addon #99

Open
bitbrain opened this issue Sep 1, 2023 · 0 comments
Open

Replace Pandora singleton access inside the addon #99

bitbrain opened this issue Sep 1, 2023 · 0 comments
Labels
⚒️ refactor Related to code refactoring.

Comments

@bitbrain
Copy link
Owner

bitbrain commented Sep 1, 2023 •
edited
Loading

Within Pandora, sometimes the Pandora singleton is directly accessed. However, this makes unit testing extremely hard and difficult to debug, as well as it can lead to unforseen side effects.

Rather, inject the required backend into the places where it is required.

This also applies to all tests!
@bitbrain bitbrain added the ⚒️ refactor Related to code refactoring. label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚒️ refactor Related to code refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bitbrain