{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":235668568,"defaultBranch":"master","name":"bdk","ownerLogin":"bitcoindevkit","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-01-22T21:16:35.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/62867074?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726362439.0","currentOid":""},"activityList":{"items":[{"before":"947071350ad40e16331d58b6053b0765a05b820b","after":"2cf46a2a9e513d3f2612b7c363446fb1acf958ae","ref":"refs/heads/master","pushedAt":"2024-09-16T16:19:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ValuedMammal","name":null,"path":"/ValuedMammal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/95981133?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1596: doc(wallet): Add docs to explain the lookahead\n\n028f687b21872b66a2907701e5a8e143d0f867a0 doc(wallet): Add docs to explain the lookahead (valued mammal)\n\nPull request description:\n\n  Adds clarifying language to `CreateParams` and `LoadParams` regarding the `lookahead` parameter. Commit 028f687b21872b66a2907701e5a8e143d0f867a0 also includes some minor documentation fixes.\n\n  If anyone is aware of any more documentation flaws that need attention I'm happy to add them here.\n\n  cc #1540\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n  LagginTimes:\n    ACK 028f687b21872b66a2907701e5a8e143d0f867a0\n  oleonardolima:\n    ACK 028f687b21872b66a2907701e5a8e143d0f867a0\n  evanlinjin:\n    ACK 028f687b21872b66a2907701e5a8e143d0f867a0\n\nTree-SHA512: 971d09652948ed2e2dc86d255cfd18607d96b0806aa0e990190cd1d7035c6660ea2ac1092ef2c6c209e61920c0d4ff9d8c0a900bcc74a8662546d284fec3218f","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2512678066\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1596\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1596/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1596\">#1596</a>: doc(wallet): Add docs to explain the lookahead"}},{"before":"88423f3a327648c6e44edd7deb15c9c92274118a","after":"947071350ad40e16331d58b6053b0765a05b820b","ref":"refs/heads/master","pushedAt":"2024-09-16T16:06:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ValuedMammal","name":null,"path":"/ValuedMammal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/95981133?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1613: ci: automated update to rustc 1.81.0\n\n503f315cdde32dabbc83efd3879ac5cb26aacdbc ci: automated update to rustc 1.81.0 (Github Action)\n\nPull request description:\n\n  Automated update to Github CI workflow `cont_integration.yml` by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action\n\nACKs for top commit:\n  ValuedMammal:\n    ACK 503f315cdde32dabbc83efd3879ac5cb26aacdbc\n\nTree-SHA512: 60269a5525d1a0aaab400d1ef287acf1b7631ea4c2e4b1627a7d66a8a40526dce79abcd4d339dfea32ef02f573672d7d76acad10319e9336949c8ce9e92a17ad","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2526681997\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1613\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1613/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1613\">#1613</a>: ci: automated update to rustc 1.81.0"}},{"before":null,"after":"503f315cdde32dabbc83efd3879ac5cb26aacdbc","ref":"refs/heads/create-pull-request/update-rust-version","pushedAt":"2024-09-15T01:07:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"create-pr-actions[bot]","name":null,"path":"/apps/create-pr-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62867074?s=80&v=4"},"commit":{"message":"ci: automated update to rustc 1.81.0","shortMessageHtmlLink":"ci: automated update to rustc 1.81.0"}},{"before":"98e1c9dc990ea2dac53c89487daf5b4534d3a551","after":"88423f3a327648c6e44edd7deb15c9c92274118a","ref":"refs/heads/master","pushedAt":"2024-09-13T21:02:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1610: Bump bdk_wallet version to 1.0.0-beta.4\n\nb34b7778f44be05827fde84660f6b1ee144d9845 Bump bdk_wallet version to 1.0.0-beta.4 (Steve Myers)\n\nPull request description:\n\n  Bump bdk_wallet version to 1.0.0-beta.4\n\n  bdk_core to 0.2.0\n  bdk_chain to 0.19.0\n  bdk_bitcoind_rpc to 0.15.0\n  bdk_electrum to 0.18.0\n  bdk_esplora to 0.18.0\n  bdk_file_store to 0.16.0\n  bdk_testenv to 0.9.0\n\nACKs for top commit:\n  ValuedMammal:\n    ACK b34b7778f44be05827fde84660f6b1ee144d9845\n\nTree-SHA512: 0dd33aca0a35adff263225678767500b0890caff1326085aa09333692e3e70095cac42b6686f1db9abc63e769326d7d4fc418d861c48ec184c877be00715b0ea","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2525613739\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1610\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1610/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1610\">#1610</a>: Bump bdk_wallet version to 1.0.0-beta.4"}},{"before":"45f750886a3ff6e736dcc5ac8b3a112df458a318","after":"98e1c9dc990ea2dac53c89487daf5b4534d3a551","ref":"refs/heads/master","pushedAt":"2024-09-13T16:01:03.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1608: Bump bdk_wallet version to 1.0.0-beta.3\n\n7a501c1c92c2859feb1a486a96f3dd9917d00a8c Bump bdk_wallet version to 1.0.0-beta.3 (Steve Myers)\n\nPull request description:\n\n  ### Description\n\n  Bump bdk_wallet version to 1.0.0-beta.3\n\n  bdk_core to 0.1.1\n  bdk_chain to 0.18.1\n  bdk_bitcoind_rpc to 0.14.1\n  bdk_electrum to 0.17.1\n  bdk_esplora to 0.17.1\n  bdk_file_store to 0.15.1\n  bdk_testenv to 0.8.1\n\nACKs for top commit:\n  ValuedMammal:\n    ACK 7a501c1c92c2859feb1a486a96f3dd9917d00a8c\n\nTree-SHA512: 75572db6c9ad4c54584c82750fbb772a66f54aa62d7bbaa2ffbad1870116e7fdeaa78136ab994840282e5b73b67d61727be6fa109fb9e4e1e414f42eee15277e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2525026787\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1608\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1608/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1608\">#1608</a>: Bump bdk_wallet version to 1.0.0-beta.3"}},{"before":"6d610bf495311af3454a56cbbf38edde3fcee037","after":"45f750886a3ff6e736dcc5ac8b3a112df458a318","ref":"refs/heads/master","pushedAt":"2024-09-12T21:16:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1605: fix(wallet): fix SingleRandomDraw to error if insufficient funds\n\n22a2f83db5df5f48974a06deef6b45d41a05ef3b fix(wallet): fix SingleRandomDraw to throw an error if insufficient funds (Steve Myers)\n\nPull request description:\n\n  ### Description\n\n  * fix SingleRandomDraw to error if insufficient funds\n  * fixed spelling and clippy errors (see: https://github.com/bitcoindevkit/bdk/pull/1581#discussion_r1756936178)\n  * updated tests to check for error variant instead of a panic\n\n  ### Notes to the reviewers\n\n  Since the single random draw algo can be used on its own it needs to be able to return an insufficient funds error. I think the reason we didn't catch this before is that single random draw already check for sufficient required + optional utxo amounts and returns the insufficient funds error.\n\n  ### Changelog notice\n\n  * fix SingleRandomDraw coin selection to error if there are insufficient funds for a requested payment amount.\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n  #### Bugfixes:\n\n  * [ ] This pull request breaks the existing API\n  * [x] I've added tests to reproduce the issue which are now passing\n  * [ ] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n  ValuedMammal:\n    ACK 22a2f83db5df5f48974a06deef6b45d41a05ef3b\n\nTree-SHA512: c434003ea6cec1423960a0c7d2f830324227f9f99d9d8f72bd7785368cf51c867036b80c300a97177a10998830ef4df924bdcad408730f9e5dddc92cda75dceb","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2523089082\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1605\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1605/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1605\">#1605</a>: fix(wallet): fix SingleRandomDraw to error if insufficie…"}},{"before":"1b50d88e4f76d466de99619b8b6be758b70b2011","after":"6d610bf495311af3454a56cbbf38edde3fcee037","ref":"refs/heads/master","pushedAt":"2024-09-12T21:12:41.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1601: fix(core): calling `CheckPoint::insert` with existing block must succeed\n\n3ae9ecba8c893750fa2ed5dfdbb1f4ee84a0b228 test: fix off-by-one in `checkpoint_insert_existing` (valued mammal)\ne6aeaea0c69472e4c2dcf0f5e2f632f43733529d doc(core): document panic for `CheckPoint::insert` (valued mammal)\n2970b83f30ca7071f0502de395327eb3671a512b fix(core): calling `CheckPoint::insert` with existing block must succeed (志宇)\n\nPull request description:\n\n  ### Description\n\n  Previously, we were panicking when the caller tried to insert a block at height 0. However, this should succeed if the block hash does not change.\n\n  ### Notes to the reviewers\n\n  For context:\n\n  * https://github.com/lightningdevkit/ldk-node/pull/358\n  * https://discord.com/channels/753336465005608961/978744259693916230/1283050849429356629\n\n  ### Changelog notice\n\n  * Fix `CheckPoint::insert` to not panic when inserting existing genesis block (same block height and hash).\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n  #### Bugfixes:\n\n  ~~* [ ] This pull request breaks the existing API~~\n  * [x] I've added tests to reproduce the issue which are now passing\n\nACKs for top commit:\n  ValuedMammal:\n    Self ACK 3ae9ecba8c893750fa2ed5dfdbb1f4ee84a0b228\n  notmandatory:\n    ACK 3ae9ecba8c893750fa2ed5dfdbb1f4ee84a0b228\n\nTree-SHA512: 638d8aacac59ad18b5ee369d08f39bb12cc37fa9b3f936404b60dbf44938ef850ca341d00566840b5a77909d31c9291ab56299d986d832005ca96cd91a0b0e55","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2521761220\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1601\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1601/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1601\">#1601</a>: fix(core): calling <code>CheckPoint::insert</code> with existing bl…"}},{"before":"9020f44e6fb85f83b631e594ba5d88267b63fe17","after":"1b50d88e4f76d466de99619b8b6be758b70b2011","ref":"refs/heads/master","pushedAt":"2024-09-12T13:46:54.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1581: Allow custom fallback algorithm for bnb\n\n65be4ead03126430ab47bf192d0de0db1b1b883a test(coin_selection): add test for deterministic utxo selection (Steve Myers)\nc18204d05925c4398e139c6e62c9640dacb67e17 feat(wallet)!: allow custom fallback algorithm for bnb (志宇)\n\nPull request description:\n\n  ### Description\n\n  This allows the caller to set a custom fallback algorithm when using `BranchAndBoundCoinSelection`. Previously, you were forced into using `SingleRandomDraw`.\n\n  Signature of `CoinSelectionAlgorithm::coin_select` has been changed to take in a `&mut RangCore`. This allows us to pass the random number generator directly to the cs algorithm.\n\n  Single random draw is now it's own type `SingleRandomDraw` and impls `CoinSelectionAlgorithm`.\n\n  `BranchAndBoundCoinSelection` now handles it's own fallback algorithm internally, and a generic type parameter is added to specify the fallback algorithm.\n\n  `coin_selection::Error` is renamed to `InsufficientFunds` and the BnB error variants are removed. The BnB error variants are no longer needed since those cases are handled internally by `BranchAndBoundCoinSelection` (via calling the fallback algorithm).\n\n  ### Notes to the reviewers\n\n  This is breaking change. Not sure how useful this is for our users. If it's deemed useful, consider including in beta.\n\n  ### Changelog notice\n\n  * Changed `CoinSelectionAlgorithm::coin_select` to take in an additional `&mut RangCore` variable. This allows us to pass a random number generator directly to the cs algorithm.\n  * Added `SingeRandomDraw` type which impls `CoinSelectAlgorithm`.\n  * Changed `BranchAndBoundCoinSelection` to call the fallback internally. An additional generic parameter is added set this.\n  * Changed `coin_selection::Error` to `coin_selection::InsufficientFunds` (which is now a struct) and therefore removing bnb error variants.\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n  oleonardolima:\n    utACK 65be4ead03126430ab47bf192d0de0db1b1b883a\n  evanlinjin:\n    self-ACK 65be4ead03126430ab47bf192d0de0db1b1b883a\n\nTree-SHA512: 3699b65dd3e9b20ad5872a05321a54d0ece61ad582eabe340d4dafbf971cf23bf46b0daa7d1284ec7bc7472d52d54cfa592c9e869ace6e35b8a9dc6938c297a3","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2491611992\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1581\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1581/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1581\">#1581</a>: Allow custom fallback algorithm for bnb"}},{"before":"a4b4946831903182cc2a540ab5bfc2c93fb5f00c","after":"9020f44e6fb85f83b631e594ba5d88267b63fe17","ref":"refs/heads/master","pushedAt":"2024-09-11T19:38:15.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1561: refactor(bdk_hwi): remove `bdk_hwi`, as `HWISigner`'s being moved to `rust-hwi`\n\ncd8ddfe18441c562342bcaccf7cae3a0d9ebbd92 chore: remove `ci/automation.json` file, used by Dockerfile.ledger (Leonardo Lima)\n75c97a6018033bbeaeeba6b69ca74b67dc47161d fix(ci)!: remove `Dockerfile.ledger` and `hwi` steps from coverage step (Leonardo Lima)\nb118b82fb08ee661ac10ac1771640b0965cf1ee8 refactor(bdk_hwi)!: remove `bdk_hwi` (Leonardo Lima)\n43257cfca6c8c2a3d5dc2b78da455ff9f16da5bd refactor(wallet)!: remove dangling unused `hardwaresigner.rs` file (Leonardo Lima)\n\nPull request description:\n\n  <!-- You can erase any parts of this template not applicable to your Pull Request. -->\n  fixes #1516\n  depends on https://github.com/bitcoindevkit/rust-hwi/pull/104\n\n  ### Description\n\n  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->\n\n  This PR removed the `bdk_hwi` crate, and the dangling `hardwaresigner.rs` file from `bdk_wallet` crate.\n\n  It simplifies the BDK project workspace as it removes the dependency on `rust-hwi`, pyo3 and some required steps on CI.\n\n  The removal is fine, as the `HWISigner` is being moved to `rust-hwi` project instead, please check: https://github.com/bitcoindevkit/rust-hwi/pull/104\n\n  ### Notes to the reviewers\n\n  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts\n  of the PR were done in a specific way -->\n\n  Please let me know what you think about the removal, and if I missed anything.\n\n  ### Changelog notice\n\n  <!-- Notice the release manager should include in the release tag message changelog -->\n  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->\n\n  - Removed dangling unused `hardwaresigner.rs` file from `bdk_wallet` crate.\n  - Removed `bdk_hwi` crate, moved to `rust-hwi` project.\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n  #### New Features:\n\n  * [ ] I've added tests for the new feature\n  * [ ] I've added docs for the new feature\n\n  #### Bugfixes:\n\n  * [ ] This pull request breaks the existing API\n  * [ ] I've added tests to reproduce the issue which are now passing\n  * [x] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n  notmandatory:\n    ACK cd8ddfe18441c562342bcaccf7cae3a0d9ebbd92\n\nTree-SHA512: 43fe716a3f107ae806b1c9bf83bd0a9f403d3c331443d78c9c4c55ac995577fd8b02ba13b77bbadb72b329e0fc94c22a7a9c8b2478ecad303d2c8db28393da2d","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2469229529\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1561\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1561/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1561\">#1561</a>: refactor(bdk_hwi): remove <code>bdk_hwi</code>, as <code>HWISigner</code>'s be…"}},{"before":"532f9062237ae948dc28c03f836584500272b9d0","after":"a4b4946831903182cc2a540ab5bfc2c93fb5f00c","ref":"refs/heads/master","pushedAt":"2024-09-11T14:20:11.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1597: fix(wallet): do `check_wallet_descriptor` when creating and loading\n\n5aecf4d6c48b75e610bbb9e31ad552878d797b5c fix(wallet): do `check_wallet_descriptor` when creating and loading (valued mammal)\n\nPull request description:\n\n  Do `check_wallet_descriptor` for both external and internal descriptors when creating a wallet, and as a defensive measure also perform the check on the descriptors loaded from a changeset.\n\n  fixes #1557\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n  notmandatory:\n    ACK 5aecf4d6c48b75e610bbb9e31ad552878d797b5c\n\nTree-SHA512: c1503cc0350894cff762925276a2b5b94ac07155df8ff85c9277fb33001bc3137f479f1b8b1c5da4401a6a1b7184467915558e1fa761ae7ccef5d8886103cdad","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2512694053\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1597\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1597/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1597\">#1597</a>: fix(wallet): do <code>check_wallet_descriptor</code> when creating …"}},{"before":"8760653339d3a4c66dfa9a54a7b9d943a065f924","after":"532f9062237ae948dc28c03f836584500272b9d0","ref":"refs/heads/master","pushedAt":"2024-09-11T14:10:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1599: fix: typos\n\nbc83e41126b75c32374a4fa6ba054c114ee62704 fix: typos (Jose Storopoli)\n\nPull request description:\n\n  <!-- You can erase any parts of this template not applicable to your Pull Request. -->\n\n  ### Description\n\n  more typos caught up during rebasing of #1320.\n\n  ### Notes to the reviewers\n\n  ### Changelog notice\n\n  <!-- Notice the release manager should include in the release tag message changelog -->\n  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n  #### New Features:\n\n  * [ ] I've added tests for the new feature\n  * [ ] I've added docs for the new feature\n\n  #### Bugfixes:\n\n  * [ ] This pull request breaks the existing API\n  * [ ] I've added tests to reproduce the issue which are now passing\n  * [ ] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n  LagginTimes:\n    ACK bc83e41126b75c32374a4fa6ba054c114ee62704\n  oleonardolima:\n    ACK bc83e41126b75c32374a4fa6ba054c114ee62704\n  thunderbiscuit:\n    ACK bc83e41126b75c32374a4fa6ba054c114ee62704.\n\nTree-SHA512: 1dc76d64ddb0273c60899a6617dcbc63fab75057447080260b7050bb5d178ef56c6f79f2c7f1ca5b7b4eb09e2b1e67d782be91598ab58e6a3b3179d6b5edf5c5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2516048443\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1599\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1599/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1599\">#1599</a>: fix: typos"}},{"before":"90a89bf8c26b39259a9311f2bdf4a96cbf8766f2","after":"8760653339d3a4c66dfa9a54a7b9d943a065f924","ref":"refs/heads/master","pushedAt":"2024-09-09T19:58:54.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1586: Change methods of `IndexedTxGraph`/`TxGraph`/`Wallet` that insert txs to be more generic\n\n87e61212f556bccfaa2a64b74f727cedc0f70e9c feat(chain,wallet)!: change methods to take in generic instead of `&Transaction` (志宇)\nc39284d8299c5a8b34b73ce947e93425d5cdc121 feat(wallet): make `Wallet::insert_tx` generic (志宇)\n67d5fa695f3f748d176c182d25be5ef70f5127ed feat(chain): make various insert tx methods more generic (志宇)\n\nPull request description:\n\n  ### Description\n\n  We want to reuse the `Arc` pointer whenever possible. However, some methods on `TxGraph` and `IndexedTxGraph` that insert transactions take in `&Transaction` or `Transaction` (thus forcing us to create a new `Arc<Transaction>` internally by cloning, even if the input tx is under a `Arc`).\n\n  This PR changes these methods to take in a generic parameter, `T: Into<Arc<Transaction>>`, allowing us to reuse the `Arc` pointer whenever possible.\n\n  ### Notes to the reviewers\n\n  Methods that previously took in `Transaction` can be changed to take in `T: Into<Arc<Transaction>>` and be non-breaking (since `Arc<T>` impls `From<T>` automatically). These changes are contained in the first two commits.\n\n  Methods that previously took in `&Transaction` will break. However, I think these api changes are small and the improvements are substantial enough to be worth it. These changes are contained in the last commit.\n\n  ### Changelog notice\n\n  * Changed `IndexedTxGraph` methods `insert_tx`, `batch_insert_relevant`, `batch_insert_relevant_unconfirmed`, `batch_insert_unconfirmed` to take in `T: Into<Arc<Transaction>>` instead of `Transaction` or `&Transaction`.\n  * Changed `TxGraph` method `batch_insert_unconfirmed` to take in `T: Into<Arc<Transaction>>` instead of `Transaction`.\n  * Changed `Wallet` methods `insert_tx`, `apply_unconfirmed_txs` to take in `T: Into<Arc<Transaction>>` instead of `Transaction` or `&Transaction`.\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n  oleonardolima:\n    utACK 87e61212f556bccfaa2a64b74f727cedc0f70e9c\n  notmandatory:\n    ACK 87e61212f556bccfaa2a64b74f727cedc0f70e9c\n\nTree-SHA512: 6be8cde80984caaaf544fa5738bc4de39428cd4cd352d242ecb73d7cf2e69794c869249e76653a32a47bb5d19e4b3a47036e063cdd32ad47642b44c99cb7ee7c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2500803260\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1586\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1586/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1586\">#1586</a>: Change methods of <code>IndexedTxGraph</code>/<code>TxGraph</code>/<code>Wallet</code> th…"}},{"before":"b49b64b14b2577c59bf709854072210c46425a34","after":"90a89bf8c26b39259a9311f2bdf4a96cbf8766f2","ref":"refs/heads/master","pushedAt":"2024-09-09T19:34:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1595: refactor(wallet): use `Amount` everywhere\n\n292ec3cb3a41d7b9f42cfea536c39b27dba16d4c refactor(wallet): use `Amount` everywhere (valued mammal)\n\nPull request description:\n\n  This is a followup to #1426 that refactors wallet internals to use `bitcoin::Amount` (nearly) everywhere. I chose not to change any public types in `coin_selection.rs` that still use `u64` as that might require more discussion.\n\n  partially addresses #1432\n  fixes #1434\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n  oleonardolima:\n    ACK 292ec3cb3a41d7b9f42cfea536c39b27dba16d4c\n  notmandatory:\n    ACK 292ec3cb3a41d7b9f42cfea536c39b27dba16d4c\n\nTree-SHA512: e84c543e796e151803321ad238023bd5f446448b4430dd6c62929180d159ee1ef867e98f69a4ef3b152c3146b8e30bbf01ce7952ac00b726847a224dca7e3be4","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2512661599\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1595\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1595/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1595\">#1595</a>: refactor(wallet): use <code>Amount</code> everywhere"}},{"before":"257c5f7f5ef2d2d333a553be5d15f1e5ce1ea709","after":"b49b64b14b2577c59bf709854072210c46425a34","ref":"refs/heads/master","pushedAt":"2024-09-09T16:32:40.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1579: fix(wallet): only mark change address used if `create_tx` succeeds\n\n606fa0874db0f10cd1c64de0f1f097b12db3a16d ci: bump actions/upload-artifact to v4 (valued mammal)\n75989d8cde3902f226bfa89aae05803b93a7cf1d test(wallet): Add `test_create_tx_increment_change_index` (valued mammal)\nb60d1d29cb8908c354b43c49237acbea373c3dc7 fix(wallet): only mark change address used if `create_tx` succeeds (valued mammal)\n\nPull request description:\n\n  If no drain script is specified in tx params then we get it from the change keychain by looking at the next unused address. Before this PR we marked the index used regardless of whether a change output is finally added. Then if creating a psbt failed, we never restored the unused status of the change address, so creating the next tx would have revealed an extra one.\n\n  We want to mark the change address used so that other callers won't attempt to use the same address between the time we create the tx and when it appears on chain. With this PR we only mark the change address used if we successfully create a psbt and the drain script is used in the change output.\n\n  fixes #1578\n\n  ### Notes to the reviewers\n\n  An early idea was to unmark the change address used if we fail to create a tx due to `InsufficientFunds`, but after looking into it I figure it doesn't totally make sense to mark the address used before we've determined that a change output is necessary. Further, `create_tx` can fail in other ways besides running coin selection, so I moved the `mark_used` logic to the end of the function.\n\n  ### Changelog notice\n\n  Fixed an issue that caused an unused internal address to be skipped when creating transactions (#1578)\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n  #### Bugfixes:\n\n  * [x] I've added tests to reproduce the issue which are now passing\n  * [x] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n  notmandatory:\n    ACK 606fa0874db0f10cd1c64de0f1f097b12db3a16d\n\nTree-SHA512: 4715494d901efccff38d636f0538f193ff32db1de44f8d56a98bb0136483f3a8ce1315901bb98117d6870d5b7e4a3bdf3d208f005e2adc0b29625f84a9e8974e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2489913446\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1579\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1579/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1579\">#1579</a>: fix(wallet): only mark change address used if `create_tx…"}},{"before":"f69eab64a1093076009134451ab8fc1f24066fd5","after":"257c5f7f5ef2d2d333a553be5d15f1e5ce1ea709","ref":"refs/heads/master","pushedAt":"2024-09-05T17:31:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1584: docs: update CONTRIBUTING.md\n\n6b881f8ab46bd0f3c612e522df21dc48ae5e6955 docs: update CONTRIBUTING.md (valued mammal)\n\nPull request description:\n\n  Update `CONTRIBUTING.md`\n\n  * Made small corrections and added some things that were missing. If there's something else you think should be included let me know.\n\n  closes #1394\n\n  ### Changelog notice\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n\nACKs for top commit:\n  LagginTimes:\n    ACK 6b881f8ab46bd0f3c612e522df21dc48ae5e6955\n  notmandatory:\n    ACK 6b881f8ab46bd0f3c612e522df21dc48ae5e6955\n  storopoli:\n    ACK 6b881f8ab46bd0f3c612e522df21dc48ae5e6955\n  oleonardolima:\n    ACK 6b881f8ab46bd0f3c612e522df21dc48ae5e6955\n\nTree-SHA512: 9a000cb86800e8dac582e2bab06613c28111268fa343d8621181e8bf1b4859029704d1258392248449c36af9dd5ecf8ab25dadfe5bcf62e40e10719a575d3b64","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2497979774\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1584\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1584/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1584\">#1584</a>: docs: update CONTRIBUTING.md"}},{"before":"23bae3e8f669a8aedad811859d20dd53ceec138d","after":"f69eab64a1093076009134451ab8fc1f24066fd5","ref":"refs/heads/master","pushedAt":"2024-09-05T05:29:22.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1477: feat(wallet): add transactions_sort_by function\n\n83a0247e8ea6afd8329af5dd9b28f9892bd5e9c1 feat(wallet): add transactions_sort_by function (Steve Myers)\n\nPull request description:\n\n  ### Description\n\n  Added new type alias `WalletTx` which represents a `CanonicalTx<'a, Arc<Transaction>, ConfirmationTimeHeightAnchor>` and new `Wallet::transactions_sort_by` that returns a `Vec<WalletTx>` sorted by the given compare function.\n\n  ### Notes to the reviewers\n\n  fixes #794\n\n  ### Changelog notice\n\n  * Add new type alias `WalletTx` which represents a `CanonicalTx<'a, Arc<Transaction>, ConfirmationTimeHeightAnchor>`.\n  * Add `Wallet::transactions_sort_by()` that returns a `Vec<WalletTx>` sorted by a given compare function.\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n  #### New Features:\n\n  * [x] I've added tests for the new feature\n  * [x] I've added docs for the new feature\n\nTop commit has no ACKs.\n\nTree-SHA512: 5758b5edf8200b5534b7a7f538de640e85083bed3da2585109190f0efda3e238f5483d4a2dc073dc4b907644f58b7158a922ebe09d03a47201030162d4b0f4d3","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2358674234\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1477\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1477/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1477\">#1477</a>: feat(wallet): add transactions_sort_by function"}},{"before":"60acb9b3a118cd63716072a090a19d0e26532d74","after":"23bae3e8f669a8aedad811859d20dd53ceec138d","ref":"refs/heads/master","pushedAt":"2024-09-05T04:06:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1590: ci: pin `tokio-util` dependency version to build with rust 1.63\n\nea6876b70eb2b1ca9ee73e5719f1a9850e11827c ci: pin `tokio-util` dependency version to build with rust 1.63 (Wei Chen)\n\nPull request description:\n\n  <!-- You can erase any parts of this template not applicable to your Pull Request. -->\n\n  ### Description\n\n  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->\n  `tokio-util` version 0.7.12 raised `msrv` to 1.70.\n  The previous version 0.7.11 was pinned to CI to continue working.\n\n  ### Notes to the reviewers\n\n  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts\n  of the PR were done in a specific way -->\n\n  ### Changelog notice\n\n  <!-- Notice the release manager should include in the release tag message changelog -->\n  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->\n  * Pinned tokio-util dependency version to build with rust 1.63.\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n  evanlinjin:\n    ACK ea6876b70eb2b1ca9ee73e5719f1a9850e11827c\n\nTree-SHA512: f200dc753fabe993bf926506e213d16050808b00eeb9c2d36fbd45cb62e0611300c660839ea37e17b0513cba2a5da48321e186d173d2871b45d2fce266f4f2b0","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2506708938\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1590\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1590/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1590\">#1590</a>: ci: pin <code>tokio-util</code> dependency version to build with ru…"}},{"before":"56970a969f99181cf1c1a3687608e5b1d3eee93e","after":"60acb9b3a118cd63716072a090a19d0e26532d74","ref":"refs/heads/master","pushedAt":"2024-09-04T23:14:44.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"LLFourn","name":"Lloyd Fournier","path":"/LLFourn","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3734083?s=80&v=4"},"commit":{"message":"Merge pull request #1587 from evanlinjin/tx_update_map_anchors\n\nfeat(core): add `TxUpdate::map_anchors`","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2502133008\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1587\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1587/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1587\">#1587</a> from evanlinjin/tx_update_map_anchors"}},{"before":"bb02ed66f4960ee2a910c9b41ea25a63efbb6df3","after":null,"ref":"refs/heads/create-pull-request/update-rust-version","pushedAt":"2024-08-30T16:01:58.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"}},{"before":"b3f0541093f315d6fb778a46e6a190229e3d6a40","after":"bb02ed66f4960ee2a910c9b41ea25a63efbb6df3","ref":"refs/heads/create-pull-request/update-rust-version","pushedAt":"2024-08-30T15:37:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"create-pr-actions[bot]","name":null,"path":"/apps/create-pr-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62867074?s=80&v=4"},"commit":{"message":"ci: automated update to rustc 1.80.1","shortMessageHtmlLink":"ci: automated update to rustc 1.80.1"}},{"before":"a8d52e658bd45eacca683b36d516950b40bb73e5","after":"56970a969f99181cf1c1a3687608e5b1d3eee93e","ref":"refs/heads/master","pushedAt":"2024-08-30T15:35:14.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1580: ci: add token for cron-update-rust.yml\n\nb140b32648241884e0e5e222fd7a0fc4e05908f1 ci: gpg commit signing for cron-update-rust.yml (Steve Myers)\n054d1483bb19e8415745033853ae0fa6943f01d9 ci: add token for cron-update-rust.yml (Steve Myers)\n\nPull request description:\n\n  ### Description\n\n  Add organization app token and GPG signing key for cron-update-rust.yml.\n\n  ### Notes to the reviewers\n\n  I went with the organization github app token option mentioned here:\n  https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs\n\n  I added gpg commit signing with below instructions. The instructions say to use PAT for signing but the plugin doesn't mention it's needed so I want to try it with only the github app token.\n  https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#gpg-commit-signature-verification\n\nACKs for top commit:\n  oleonardolima:\n    ACK b140b32648241884e0e5e222fd7a0fc4e05908f1\n  ValuedMammal:\n    ACK b140b32648241884e0e5e222fd7a0fc4e05908f1\n\nTree-SHA512: 0730264ccd39645bbfe496abb43e5ac4c16de1ca9032ede4310ec190c4441152fa8adef09cf73c28c9b547d0de41e34431df88deba7d706389df564907081583","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2490931028\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1580\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1580/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1580\">#1580</a>: ci: add token for cron-update-rust.yml"}},{"before":"775e4aee3a9ec2d99adb129f7a9367a3a15c7032","after":"a8d52e658bd45eacca683b36d516950b40bb73e5","ref":"refs/heads/master","pushedAt":"2024-08-29T14:55:57.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1425: chore: add `print_stdout`/`print_stderr` lints to workspace level\n\ne063ad89bde62e60b10435260e736c66515bf447 fix(esplora+wallet+file_store): remove remaining `println!` usage (Leonardo Lima)\nb32b9447e089709b66f24d5700750f0aa6b8d6e1 chore(examples): allow `clippy::print_stdout` in examples (Leonardo Lima)\nb614237127ec1e760414fcc8ee7c4b0c77c62d46 fix(tests)!: remove println! usage from tests (Leonardo Lima)\neaa1917a46245e177ad3e65b53e34c681f0043d0 chore: add `print_stdout`/`print_stderr` lints to workspace level (Leonardo Lima)\n\nPull request description:\n\n  potentially fixes #1362\n  <!-- You can erase any parts of this template not applicable to your Pull Request. -->\n\n  ### Description\n\n  It adds both `print_stdout` and `print_stderr` deny level lints on workspace level, but it does allow it on test fns through `clippy.toml` settings, and explicitly allow it on example code.\n\n  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->\n\n  ### Notes to the reviewers\n  It currently has the setting allowing it on test fns, but open for discussion below.\n\n  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts\n  of the PR were done in a specific way -->\n\n  ### Changelog notice\n\n  - Add both `print_stdout` and `print_stderr` deny level lints on workspace level\n\n  <!-- Notice the release manager should include in the release tag message changelog -->\n  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n  #### New Features:\n\n  * [x] I've added tests for the new feature\n  * [x] I've added docs for the new feature\n\nACKs for top commit:\n  notmandatory:\n    ACK e063ad89bde62e60b10435260e736c66515bf447\n\nTree-SHA512: b3348efd86d09944eb36e4d87799eebc23f4e423861b3bad08365d286449f61b29ad332157eecfb7307191ef61d3b8285341e0ccb868581e54b570d6dd37547c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2279584930\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1425\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1425/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1425\">#1425</a>: chore: add <code>print_stdout</code>/<code>print_stderr</code> lints to worksp…"}},{"before":"5e4b0355943fa7a6b95c5007aa1c6d4461c761f0","after":"775e4aee3a9ec2d99adb129f7a9367a3a15c7032","ref":"refs/heads/master","pushedAt":"2024-08-25T18:03:02.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1573: chore: add missing bdk_core README.md and remove specific bdk_chain dev version\n\n48b6a66f6e0edce305d41653f37b8549aaf7c060 chore(core): remove bdk_chain dev-dependency version (Steve Myers)\n9bd500f5f198df4dfc72a1f71c93f9b20d65431d chore(core): add missing README.md (Steve Myers)\n\nPull request description:\n\n  Add the missing README.md file for the bdk_core crate. This is required to publish to crates.io.\n\n  Also had to removed fixed bdk_chain version from bdk_core dev dependencies to prevent missing dependency when publishing bdk_core before publishing new version of bdk_chain.\n\nACKs for top commit:\n  ValuedMammal:\n    ACK 48b6a66f6e0edce305d41653f37b8549aaf7c060\n\nTree-SHA512: 5fb31984f79771c5366ca078efa11330b24fd4d97e90531a2ba8f92ce6361c6dd4f123e8640269de9235bc5ebf3e6b5ced261e36f5b40f01db3f82add9a5ae68","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2485383759\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1573\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1573/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1573\">#1573</a>: chore: add missing bdk_core README.md and remove specifi…"}},{"before":"4b9c23087ef3e7793936eae4e0ecbca0a6b7549f","after":null,"ref":"refs/tags/v1.0.0-beta.2","pushedAt":"2024-08-25T17:17:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"}},{"before":"e9d0cd97ef2b70233d7c0b5ed416f78263342657","after":"5e4b0355943fa7a6b95c5007aa1c6d4461c761f0","ref":"refs/heads/master","pushedAt":"2024-08-25T16:09:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1572: Bump bdk version to 1.0.0-beta.2\n\n092e9be454b3f1f4754f3fefb70b203d7e86c423 Bump bdk version to 1.0.0-beta.2 (Steve Myers)\n\nPull request description:\n\n  Bump versions for bdk 1.0.0-beta.2 release:\n\n  bdk version to 1.0.0-beta.2\n  bdk_chain to 0.18.0\n  bdk_bitcoind_rpc to 0.14.0\n  bdk_electrum to 0.17.0\n  bdk_esplora to 0.17.0\n  bdk_file_store to 0.15.0\n  bdk_testenv to 0.8.0\n  bdk_hwi to 0.5.0\n\nACKs for top commit:\n  ValuedMammal:\n    ACK 092e9be454b3f1f4754f3fefb70b203d7e86c423\n\nTree-SHA512: 39f5cb6efd413ac5efc1736176bf846a727f22f2dcabcae97e726f6793e0b8586358193531aca9118f141e313f21a3f63b6b3ed13343df40940d8435ab6264f3","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2485324530\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1572\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1572/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1572\">#1572</a>: Bump bdk version to 1.0.0-beta.2"}},{"before":"dad95454f323bdcb6fed580a6be7b68f4d6b96af","after":"e9d0cd97ef2b70233d7c0b5ed416f78263342657","ref":"refs/heads/master","pushedAt":"2024-08-25T13:34:56.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1569: Introduce `bdk_core`\n\na5d076f215cd91173f55bda0d1cc59b9dde75511 chore(core)!: s/tx_graph::Update/TxUpdate/ (LLFourn)\ndafb9aaef7d8d4bc83c8ba0845323b92b82fbb3d feat(bitcoind_rpc)!: depend on `bdk_core` instead of `bdk_chain` (志宇)\nfea8eede760130db32c2cfaecc272f6c1ed979db feat(esplora)!: depend on `bdk_core` instead of `bdk_chain` (志宇)\n0d302f5f204eeac8902a4b5943b9b820c6b575ab feat(electrum)!: depend on `bdk_core` instead of `bdk_chain` (志宇)\nab0315d14fa741a691ee0deef4567ea66cb44a60 feat!: move `spk_client`s to `bdk_core` (志宇)\nbdea871a0d0d337772f226fdcf5cd734f3d857ba feat!: move `tx_graph::Update` to `bdk_core` (志宇)\n77e31c71a5edc011df42daece1920903bc2b866f feat!: move `CheckPoint` to `bdk_core` (志宇)\na86c878a60f40ce30ab00c0b47fa6cddf30cfe30 refactor(chain): change `CheckPoint::apply_changeset` (志宇)\n6f7626ad0bb6ca7e45428af11dbf930d746d9cd0 feat!: introduce `bdk_core` (志宇)\n\nPull request description:\n\n  Based on #1568\n  Closes #1543\n\n  ### Description\n\n  Introduce `bdk_core` crate. Move types over from `bdk_chain`. Chain sources (`bdk_electrum`, `bdk_esplora` and `bdk_bitcoind_rpc`) now only depend on `bdk_core`.\n\n  ### Notes to the reviewers\n\n  Please review commit-by-commit. I've moved things over, but slight API changes were necessary (mentioned in the commit messages).\n\n  ### Changelog notice\n\n  * Add `bdk_core` crate which contains core types that were previously in `bdk_chain`. Including: `BlockId`, `ConfirmationBlockTime`, `CheckPoint`, `CheckPointIter`, `tx_graph::Update` and `spk_client`-types.\n  * Change chain sources (`bdk_esplora`, `bdk_electrum` and `bdk_bitcoind_rpc`) to only depend on `bdk_core`.\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n  LLFourn:\n    Self-ACK: a5d076f215cd91173f55bda0d1cc59b9dde75511\n  evanlinjin:\n    ACK a5d076f215cd91173f55bda0d1cc59b9dde75511\n\nTree-SHA512: 13ecd0a2d2fc840b281977f07dc11fed27459f77c676af470134d2184db4a1fc352073ef82b1622e04fc60edb885e587ae8b9909c9bafb4ae63fcd51325d1cad","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2483352555\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1569\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1569/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1569\">#1569</a>: Introduce <code>bdk_core</code>"}},{"before":"9e6ac72a630f378d3fa6d6b6cbfb763eedd3539a","after":"dad95454f323bdcb6fed580a6be7b68f4d6b96af","ref":"refs/heads/master","pushedAt":"2024-08-25T04:26:01.000Z","pushType":"pr_merge","commitsCount":7,"pusher":{"login":"LLFourn","name":"Lloyd Fournier","path":"/LLFourn","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3734083?s=80&v=4"},"commit":{"message":"Merge pull request #1568 from evanlinjin/tx_graph_update\n\nIntroduce `tx_graph::Update` and simplify `TxGraph` update logic","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2482403338\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1568\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1568/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1568\">#1568</a> from evanlinjin/tx_graph_update"}},{"before":null,"after":"b3f0541093f315d6fb778a46e6a190229e3d6a40","ref":"refs/heads/create-pull-request/update-rust-version","pushedAt":"2024-08-23T15:17:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"ci: automated update to rustc 1.80.1","shortMessageHtmlLink":"ci: automated update to rustc 1.80.1"}},{"before":"6008897aac7f9815fde5362348b74e6d79c62b59","after":"9e6ac72a630f378d3fa6d6b6cbfb763eedd3539a","ref":"refs/heads/master","pushedAt":"2024-08-23T15:14:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1564: ci: add cron-update-rust.yml\n\nb92f8c9ac1e000ccced89dc597a8ff278842d5ed ci: add cron-update-rust.yml (valued mammal)\n\nPull request description:\n\n  This adds a cronjob to watch for updates to rust stable once a month. If the latest version changed, then a pull request is opened to see if clippy passes CI using the new toolchain.\n\n  ### Notes to the reviewers\n\n  Let me know what you think @notmandatory\n\n  fixes #1431\n\n  ### Changelog notice\n\n  ### Checklists\n\n  #### TODO\n\n  * [ ] Setup access token for [create-pull-request](https://github.com/marketplace/actions/create-pull-request)\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n  oleonardolima:\n    tACK b92f8c9ac1e000ccced89dc597a8ff278842d5ed\n\nTree-SHA512: e251fb8d0456c30a244f4611131baea1afc4f8323a3bdc8d9536d276a8b4bb2c0269beba6b04b72ab2ea96897e421a16c3e8e6065a755d62ff98bfe13d0b02bd","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2476978312\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1564\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1564/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1564\">#1564</a>: ci: add cron-update-rust.yml"}},{"before":"37314dc6d72fddb3c21734d70cb0ac0cd162d2ef","after":"6008897aac7f9815fde5362348b74e6d79c62b59","ref":"refs/heads/master","pushedAt":"2024-08-22T06:48:09.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1562: fix(wallet)!: make `LoadParams` implicitly satisfy `Send`\n\n295b9794caf142707c49666529268197694534e7 fix(wallet)!: make `LoadParams` implicitly satisfy `Send` (志宇)\n\nPull request description:\n\n  ### Description\n\n  Make `LoadParams` implicitly satisfy `Send`. This will hopefully make `AsyncWalletPersister` easier to implement.\n\n  Refer to the [conversation on Discord](https://discord.com/channels/753336465005608961/753367451319926827/1273667818528964714).\n\n  cc. @matthiasdebernardini\n\n  ### Notes to the reviewers\n\n  This is a breaking change, since we are tightening the bounds to some methods.\n\n  ### Changelog notice\n\n  * Change `LoadParams` to implicitly satisfy `Send`.\n\n  ### Checklists\n\n  #### All Submissions:\n\n  * [x] I've signed all my commits\n  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n  * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n  LLFourn:\n    ACK 295b9794caf142707c49666529268197694534e7\n  notmandatory:\n    ACK 295b9794caf142707c49666529268197694534e7\n\nTree-SHA512: 952cd7fbb058166af93af0b8afa3e0f3c1afe600f5782364da8e3c74e7388ca682bab34e2c60b221055e25ade2f6ddb4a2e9451d6d181f14b0bcca053522155c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2469440846\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoindevkit/bdk/issues/1562\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoindevkit/bdk/pull/1562/hovercard\" href=\"https://github.com/bitcoindevkit/bdk/pull/1562\">#1562</a>: fix(wallet)!: make <code>LoadParams</code> implicitly satisfy <code>Send</code>"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEt6Uz_AA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoindevkit/bdk"}