Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support monolith build target #14

Open
bnoordhuis opened this issue Apr 13, 2020 · 2 comments
Open

Support monolith build target #14

bnoordhuis opened this issue Apr 13, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bnoordhuis
Copy link
Owner

Port the v8_monolith build target to cmake. The monolith is a single static library that combines the separate libraries into a single "super" library.

v8-cmake/v8/BUILD.gn

Lines 3971 to 3988 in 6a73df8

if (v8_monolithic) {
# A component build is not monolithic.
assert(!is_component_build)
# Using external startup data would produce separate files.
assert(!v8_use_external_startup_data)
v8_static_library("v8_monolith") {
deps = [
":v8",
":v8_libbase",
":v8_libplatform",
":v8_libsampler",
"//build/win:default_exe_manifest",
]
configs = [ ":internal_config" ]
}
}

@bnoordhuis bnoordhuis added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 13, 2020
@JerrySievert
Copy link
Contributor

given that I need this myself, do you have an example of a commit that would help to implement this? my cmake-foo is low, but I'm willing to try.

@bnoordhuis
Copy link
Owner Author

No commits I can point you to but you can glean the logic from BUILD.bazel or BUILD.gn. The main challenge is that you must first build a non-snapshot build to create the snapshot before you can create the monolith library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants