Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't zlib from third_party in v8 be also included in not ignore list #76

Open
aytiwari opened this issue Nov 6, 2023 · 1 comment

Comments

@aytiwari
Copy link

aytiwari commented Nov 6, 2023

The zlib from third_party is being referred in CMakes.list, but that gets ignored by the .gitignore present in v8, which creates an issue.

@bnoordhuis
Copy link
Owner

We can probably simply remove that file. For my curiosity, what specific issue did you hit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants