Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisArg in merge - really necessary? #27

Open
bergus opened this issue Jul 13, 2016 · 1 comment
Open

thisArg in merge - really necessary? #27

bergus opened this issue Jul 13, 2016 · 1 comment

Comments

@bergus
Copy link
Contributor

bergus commented Jul 13, 2016

The merge callback f is called with the this of the merge(…) call as the receiver. This doesn't seem exactly useful to me.
Are there any use cases? Does any code use merge.call(o, f, …) instead of merge(f.bind(o), …)?
Could we just drop this "feature"?

@briancavalier
Copy link
Owner

Not sure what I was thinking there :) Totally agree that f.bind(o) makes much more sense, and seems much more obvious. Let's drop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants