some emoji missing or different set supported?

[drnic]

What is bk's relationship with https://github.com/buildkite/emojis?

In the example pipeline below, only :thumbsup: is supported by bk:

steps:
  - command: "sleep 2"
    label: ":thumbsup:"
  - command: "sleep 2"
    label: ":thumbsup::skin-tone-2:"
  - command: "sleep 2"
    label: ":+1:"
  - command: "sleep 2"
    label: ":+1::skin-tone-2:"

The output includes:

>>> Executing command step 👍
...
>>> Executing command step 👍:skin-tone-2:
...
>>> Executing command step :+1:
...
>>> Executing command step :+1::skin-tone-2:

[keithpitt]

Ah, I think I see what's happening. We're not taking into consideration the emoji variations.

The golang version is here:

cli/local/emoji.go

Lines 72 to 96 in e635a7d

	func (el *emojiLoader) Render(line string) string {
	return emojiRegexp.ReplaceAllStringFunc(line, func(s string) string {
	bkEmojis, err := el.buildkiteEmojis()
	if err != nil {
	log.Printf("Err: %v", err)
	return s
	}
	if e, ok := bkEmojis.Match(s); ok {
	return e.Render(el.cache)
	}
	appleEmojis, err := el.appleEmojis()
	if err != nil {
	log.Printf("Err: %v", err)
	return s
	}
	if e, ok := appleEmojis.Match(s); ok {
	return e.Render()
	}
	return s
	})
	}

Which just looks up the emoji in the list, but in the Ruby version, there's some pre-processing going on: https://github.com/buildkite/docs/blob/master/app/models/emoji/catalogue.rb#L34-L49

I don't have time to craft a fix, but a PR would be welcome! :D:D

[drnic]

Ok will investigate later.

I want my pipelines to have randomized skin color :)