Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change Request]: Research aria attributes on components #194

Open
3 tasks done
chromaticWaster opened this issue Oct 23, 2023 · 2 comments
Open
3 tasks done

[Change Request]: Research aria attributes on components #194

chromaticWaster opened this issue Oct 23, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@chromaticWaster
Copy link
Contributor

chromaticWaster commented Oct 23, 2023

What type of enhancement/feature is this?

Behaviour Changes to existing UI Components, Documentation Improvements, Other

Description

Investigate using aria attributes on existing web components.

Currently the web components developed does not have full accessibility support. This is required for future proofing the components to cater for accessibility.

The following should be confirmed

How the current testing implementation of the components can be streamlined.
What accessibility attributes will be required for specific components (Labels vs Inputs).

Use Case/Reasoning for enhancement/feature.

Simplify the tests written for components.
Provide accessibility compliant components.
Understand which aria roles and aria attributes will be required for each component.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
  • This is a single enhancement/feature
@chromaticWaster chromaticWaster added enhancement New feature or request question Further information is requested labels Oct 23, 2023
@chromaticWaster chromaticWaster self-assigned this Oct 23, 2023
@chromaticWaster chromaticWaster changed the title [Change Request]: Implement aria attributes on components [Change Request]: Research aria attributes on components Oct 23, 2023
@chromaticWaster
Copy link
Contributor Author

Note the following test case the aria-label attribute was added to the text field component a comparison using the browser extension lighthouse was used to compare the results of the same view on the Omni-components doc site.

Before aria-label added

image

After aria-label added

image

@chromaticWaster
Copy link
Contributor Author

The following aria attributes should be considered (Note this comment will have edits as more attributes are confirmed)

aria-label
aria-disabled
aria-checked
aria-error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant