Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Accordion items do not animate #17197

Open
2 tasks done
tay1orjones opened this issue Aug 16, 2024 · 1 comment · May be fixed by #17418
Open
2 tasks done

[Bug]: Accordion items do not animate #17197

tay1orjones opened this issue Aug 16, 2024 · 1 comment · May be fixed by #17418
Assignees
@alisonjoseph
Labels
component: accordion role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@tay1orjones
Copy link
Member

Package

@carbon/react

Browser

Chrome

Package version

11.64.0

React version

18

Description

Regression caused by #16933, the accordion does not animate when opening and closing items.

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-accordion--default

Steps to reproduce

Go to the story and click to open an item. It does not smoothly transition as it did before in 11.63.0: https://deploy-preview-17079--v11-carbon-react.netlify.app/?path=/story/components-accordion--default

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

No response

Code of Conduct
@alisonjoseph alisonjoseph self-assigned this Aug 29, 2024
@alisonjoseph
Copy link
Member

Regression actually seems to be caused by this #17120 adding hidden removes the element before it can animate.

@alisonjoseph alisonjoseph linked a pull request Sep 11, 2024 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alisonjoseph alisonjoseph

Labels
component: accordion role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Status: 🏗 In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(accordion): add transition styles back alisonjoseph/carbon
2 participants
@alisonjoseph @tay1orjones