Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HeaderPanel): replace hardcoded prefix in CSS selector #17422

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Sep 11, 2024

Closes #16908

replaces hardcoded CSS prefix

Changelog

  • CSS prefix in blur listener

Testing / Reviewing

confirm that the component behavior on blur remains unchanged

@emyarod emyarod requested a review from a team as a code owner September 11, 2024 18:32
emyarod added a commit to emyarod/carbon that referenced this pull request Sep 11, 2024
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d2ee9dc
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e33b7581ea6d0008008967
😎 Deploy Preview https://deploy-preview-17422--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit d2ee9dc
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e33b7561cb20000895d3e1
😎 Deploy Preview https://deploy-preview-17422--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-merge-queue bot pushed a commit that referenced this pull request Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.82%. Comparing base (fdb31d9) to head (d2ee9dc).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...kages/react/src/components/UIShell/HeaderPanel.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17422   +/-   ##
=======================================
  Coverage   76.82%   76.82%           
=======================================
  Files         408      408           
  Lines       13973    13973           
  Branches     4341     4341           
=======================================
  Hits        10735    10735           
  Misses       3064     3064           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennylam kennylam added this pull request to the merge queue Sep 13, 2024
Merged via the queue into carbon-design-system:main with commit 885a114 Sep 13, 2024
36 checks passed
@emyarod emyarod deleted the 16908-fix/hardcoded-HeaderPanel-selector-prefix branch September 13, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: HeaderPanel focus listener uses hardcoded CSS prefix
5 participants