Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the error state for "username already exists" #671

Open
3 tasks
clicksave opened this issue Sep 7, 2024 · 6 comments
Open
3 tasks

Update the error state for "username already exists" #671

clicksave opened this issue Sep 7, 2024 · 6 comments
Assignees

Comments

@clicksave
Copy link

Lets make it easier to move from log in to sign up when a user inputs a invalid/taken username

image

Doing a few things here

  • removes the alert icon
  • changes the copy
  • adds an inline 'Log in button'
image

Figma


Lets use a similar pattern on sign up as well

image

Figma

@bitfalt
Copy link

bitfalt commented Sep 12, 2024

hii! I'd love to work on this. Just to get the task clear, I would need to update the error state and make it like the Figma designs which would be to fulfill the tasks you mentioned:

  • Remove the alert icon
  • Changes the copy (I would like to know what you mean exactly by this)
  • Add an inline 'Log in' button.

@clicksave
Copy link
Author

gm @bitfalt you can have this ticket if you'd like but I just wanted to confirm. The controller isn't an open source project so theres no bounty for this work. lmk if you still want it

@bitfalt
Copy link

bitfalt commented Sep 12, 2024

okay okay, no worries! I'll still be happy to help :D

@clicksave
Copy link
Author

Awesome! ok, to answer your question, I'm referring to the contents of the error message

  • The copy for the error state on the Sign Up page currently reads "Controller with username not found" it should instead read "Username not found"
  • The copy for the error state on the Log In page currently reads "Account already exists" it should instead read "Sorry, [username] already exists."

You can test it yourself here if you'd like
https://flippyflop.gg/

@clicksave
Copy link
Author

hii! I'd love to work on this. Just to get the task clear, I would need to update the error state and make it like the Figma designs which would be to fulfill the tasks you mentioned:

  • Remove the alert icon
  • Changes the copy (I would like to know what you mean exactly by this)
  • Add an inline 'Log in' button.

This is correct by the way! and you'd do it for both the log in and sign up pages

@bitfalt
Copy link

bitfalt commented Sep 12, 2024

Alright, sounds good! I'll start working on this issue and do a draft PR, so you can check my progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants