Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a helm chart version that isn't in the form x.y.z doesn't work even though it is valid SemVer-2 #1747

Open
TheGoldMonkey opened this issue Jan 8, 2024 · 0 comments
Labels
bug Something isn't working effort/small 1 day tops priority/p2 Dependent on community feedback. PR's are welcome :)

Comments

@TheGoldMonkey
Copy link

TheGoldMonkey commented Jan 8, 2024

Description of the bug:

Importing a helm chart version that isn't in the form x.y.z doesn't work even though it is valid SemVer-2. I am trying to import a prerelease version which has the version 1.15.0-rc.0.
https://semver.org/#spec-item-9

Reproduction Steps:

Start a plain cdk8s project and run cdk8s import with the following cdk8s.yaml:

language: typescript
app: npx ts-node main.ts
imports:
  - helm:https://helm.cilium.io/[email protected]

Error Log:

Error: Invalid helm URL: helm:https://helm.cilium.io/[email protected]. Must match the format: 'helm:<repo-url>/<chart-name>@<chart-version>'.
    at extractHelmChartDetails (/root/.local/share/pnpm/global/5/.pnpm/[email protected]/node_modules/cdk8s-cli/lib/import/helm.js:116:19)
    at new ImportHelm (/root/.local/share/pnpm/global/5/.pnpm/[email protected]/node_modules/cdk8s-cli/lib/import/helm.js:47:53)
    at ImportHelm.fromSpec (/root/.local/share/pnpm/global/5/.pnpm/[email protected]/node_modules/cdk8s-cli/lib/import/helm.js:42:16)
    at matchImporter (/root/.local/share/pnpm/global/5/.pnpm/[email protected]/node_modules/cdk8s-cli/lib/import/dispatch.js:37:34)
    at async importDispatch (/root/.local/share/pnpm/global/5/.pnpm/[email protected]/node_modules/cdk8s-cli/lib/import/dispatch.js:13:26)
    at async Object.handler (/root/.local/share/pnpm/global/5/.pnpm/[email protected]/node_modules/cdk8s-cli/lib/cli/cmds/import.js:34:9)

Environment:

  • Framework Version: 2.198.25
  • OS: Ubuntu WSL2 Windows 11

Other:


This is 🐛 Bug Report

@TheGoldMonkey TheGoldMonkey added bug Something isn't working needs-triage Priority and effort undetermined yet labels Jan 8, 2024
@sumupitchayan sumupitchayan added effort/small 1 day tops priority/p2 Dependent on community feedback. PR's are welcome :) and removed needs-triage Priority and effort undetermined yet labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/small 1 day tops priority/p2 Dependent on community feedback. PR's are welcome :)
Projects
None yet
Development

No branches or pull requests

2 participants