Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of instanceof for Lazy #2164

Open
rassie opened this issue Feb 15, 2024 · 0 comments
Open

Remove usage of instanceof for Lazy #2164

rassie opened this issue Feb 15, 2024 · 0 comments
Labels
bug Something isn't working @component/cdk8s-core Issue related to cdk8s-core effort/medium 1 week tops priority/p1 Should be on near term plans

Comments

@rassie
Copy link

rassie commented Feb 15, 2024

Description of the bug:

This is basically the same issue as cdk8s-team/cdk8s-core#581, but for code introduced after that change (in cdk8s-team/cdk8s-core#1573).

LazyResolver uses instanceof to check for instances of Lazy, which fails in a fair amount of cases similar to those described in cdk8s-team/cdk8s-core#581:

https://github.com/cdk8s-team/cdk8s-core/blob/fe4afa3ddc808e3fc87fe67b84334fa2400f4fe0/src/resolve.ts#L58-L69

The solution can probably be similar to cdk8s-team/cdk8s-core#1112.

This is 🐛 Bug Report

@rassie rassie added bug Something isn't working needs-triage Priority and effort undetermined yet labels Feb 15, 2024
@iliapolo iliapolo added effort/medium 1 week tops priority/p1 Should be on near term plans and removed needs-triage Priority and effort undetermined yet labels Jun 1, 2024
@iliapolo iliapolo added the @component/cdk8s-core Issue related to cdk8s-core label Sep 20, 2024
@iliapolo iliapolo transferred this issue from cdk8s-team/cdk8s-core Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @component/cdk8s-core Issue related to cdk8s-core effort/medium 1 week tops priority/p1 Should be on near term plans
Projects
None yet
Development

No branches or pull requests

2 participants