Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying multiple dockerRegistryAuths. #2181

Open
1 of 2 tasks
HamishWHC opened this issue Jan 6, 2024 · 1 comment
Open
1 of 2 tasks

Allow specifying multiple dockerRegistryAuths. #2181

HamishWHC opened this issue Jan 6, 2024 · 1 comment
Labels
@component/cdk8s-plus Issue related to cdk8s-plus effort/medium 1 week tops feature-request New/Enhanced functionality wanted priority/p2 Dependent on community feedback. PR's are welcome :)

Comments

@HamishWHC
Copy link

Description of the feature or enhancement:

Currently, only a single secret for registry auth is accepted when creating a pod/deployment. The K8s spec allows for mutiple to be specified, so that we can pull images from multiple sources if needed.

Use Case:

I need my pods to include a container from my own registry plus a sidecar from a public registry.

Proposed Solution:

Unsure how best to make a change like this - not all the supported languages allow for args to be multiple types like in TS or Python AFAIK (in those languages you could just allow ISecret | ISecret[]/Python equivalent to avoid breaking existing code), so potentially adding a new property? Seems clunky though.

Other:

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@HamishWHC HamishWHC added feature-request New/Enhanced functionality wanted needs-triage Priority and effort undetermined yet labels Jan 6, 2024
@iliapolo
Copy link
Member

iliapolo commented Jun 2, 2024

Yeah this unfortunate, but a new property/method would be required to avoid a breaking change. Still ok.

@iliapolo iliapolo added priority/p2 Dependent on community feedback. PR's are welcome :) effort/medium 1 week tops and removed needs-triage Priority and effort undetermined yet labels Jun 2, 2024
@iliapolo iliapolo added the @component/cdk8s-plus Issue related to cdk8s-plus label Sep 20, 2024
@iliapolo iliapolo transferred this issue from cdk8s-team/cdk8s-plus Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@component/cdk8s-plus Issue related to cdk8s-plus effort/medium 1 week tops feature-request New/Enhanced functionality wanted priority/p2 Dependent on community feedback. PR's are welcome :)
Projects
None yet
Development

No branches or pull requests

2 participants