Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data collocated even when no data for variable is not available #21

Open
tommibergman opened this issue Jul 4, 2019 · 7 comments
Open

Comments

@tommibergman
Copy link

With AERONET data there some stations that do not have any data for a given variable and year (there are other variables but not this one). Now I have an automatic script which collocates model data to AERONET. With earlier versions (at least 1.4) collocating to empty data would result in empty collocated data as well. But with v1.7.1 I am getting values for collocated data even when AERONET has no data. Of course I can do a work around, but I feel this is a reduction in usability.

@adamcpovey
Copy link
Contributor

Could you provide a minimal example of the collocation you're running? I haven't encountered this problem but have a suspicion what it might be.

@duncanwp
Copy link
Member

duncanwp commented Jul 4, 2019

This can be controlled using the 'missing_data_for_missing_sample' keyword argument, are you using the Python or command line interface?

@tommibergman
Copy link
Author

This can be controlled using the 'missing_data_for_missing_sample' keyword argument, are you using the Python or command line interface?

I have some older scripts which still use command line interface. Does this mean that I would get more control if I would use the Python?

@duncanwp
Copy link
Member

duncanwp commented Jul 4, 2019

Yes, I tend to only use the Python interface now, it's not as well documented yet but it gives you much more flexibility. See this example notebook to get you going :-)

@tommibergman
Copy link
Author

Could you provide a minimal example of the collocation you're running? I haven't encountered this problem but have a suspicion what it might be.

I made a small test set with one month in my google drive https://drive.google.com/open?id=1sQftoLxgBbRkrpn0-x6DbaIGlOfyFccV .

running test from there will produce a subset of banizombou station and the colocate my data on it. And the collocated data has data while the subset does not.

@tommibergman
Copy link
Author

I was also wondering why do they get different missing value? AERONET has -999 and model data NaN.

@tommibergman
Copy link
Author

I was also wondering why do they get different missing value? AERONET has -999 and model data NaN.

Sorry, my mistake. This is just a difference between an old and a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants