Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blob)!: update the blob.Proof to return a proof to the data root #3610

Merged
merged 52 commits into from
Aug 7, 2024
Merged

fix(blob)!: update the blob.Proof to return a proof to the data root #3610

merged 52 commits into from
Aug 7, 2024

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jul 31, 2024

Closes #3582

@rach-id rach-id self-assigned this Jul 31, 2024
@github-actions github-actions bot added the external Issues created by non node team members label Jul 31, 2024
rach-id
rach-id commented Jul 31, 2024
View reviewed changes
blob/blob.go Outdated Show resolved Hide resolved
@rach-id rach-id mentioned this pull request Jul 31, 2024
Open
@vgonkivs vgonkivs added the kind:misc Attached to miscellaneous PRs label Jul 31, 2024
@Wondertan Wondertan added kind:fix Attached to bug-fixing PRs and removed kind:misc Attached to miscellaneous PRs labels Jul 31, 2024
cristaloleg
cristaloleg reviewed Aug 5, 2024
View reviewed changes
blob/service.go Outdated Show resolved Hide resolved
Wondertan
Wondertan reviewed Aug 5, 2024
View reviewed changes
blob/blob.go Show resolved Hide resolved
renaynay
renaynay reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment here otherwise thank u for tests :)

blob/service_test.go Show resolved Hide resolved
@vgonkivs
Copy link
Member

vgonkivs commented Aug 5, 2024

Btw, unit test failed

@rach-id
Copy link
Member Author

rach-id commented Aug 5, 2024

Unit test fixed: 712c272

was a good catch 👍

vgonkivs
vgonkivs previously approved these changes Aug 5, 2024
View reviewed changes
renaynay
renaynay previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rach-id let's get this over the line :)

blob/blob.go Show resolved Hide resolved
Wondertan
Wondertan reviewed Aug 6, 2024
View reviewed changes
blob/blob.go Show resolved Hide resolved
@rach-id rach-id dismissed stale reviews from renaynay and vgonkivs via 26de33e August 6, 2024 10:48
@rach-id rach-id mentioned this pull request Aug 6, 2024
Open
@renaynay renaynay removed the v0.15.0 Intended for v0.15.0 release label Aug 6, 2024
@rach-id rach-id changed the base branch from main to feature_branch_blob_proof August 7, 2024 10:11
@vgonkivs vgonkivs merged commit 32d3137 into celestiaorg:feature_branch_blob_proof Aug 7, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@ramin ramin Awaiting requested review from ramin

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@cristaloleg cristaloleg Awaiting requested review from cristaloleg cristaloleg is a code owner

Assignees

@rach-id rach-id

Labels
external Issues created by non node team members kind:break! Attached to breaking PRs kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge GetCommitmentProof with GetProof
6 participants
@rach-id @codecov-commenter @vgonkivs @cristaloleg @Wondertan @renaynay