feat(nodebuilder/da): implement go-da v0.6.1 changes #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
2 times, most recently
from
269c6e8
to
9332823
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3750 +/- ##
==========================================
+ Coverage 44.83% 45.53% +0.70%
==========================================
Files 265 281 +16
Lines 14620 16090 +1470
==========================================
+ Hits 6555 7327 +772
- Misses 7313 7924 +611
- Partials 752 839 +87 ☔ View full report in Codecov by Sentry. |
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
c835b77
to
616465f
Compare
tzdybal
changed the title
This change ensures that if the options byte slice is empty, the parseOptions function returns an empty slice of ConfigOption without proceeding to unmarshal. This prevents potential errors and enhances the function's robustness.
…st loop The reassignment of 'tt' within the loop is unnecessary and redundant. This cleanup simplifies the code and reduces potential confusion during code reviews.
Unskip DA tests in `da_test.go` and correct parameter usage in test functions to ensure accurate comparisons. This allows the full test suite to run and verifies the integrity of the Data Availability logic.
Introduced tests for the SubmitWithOptions method to ensure correct behavior with valid and invalid input. These tests validate the API's handling of well-formed requests and error scenarios, improving the robustness of the DA client.
tzdybal
force-pushed
the
tzdybal/new_go_da
branch
from
616465f
to
8a4573d
Compare
tzdybal
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
cristaloleg
as code owners
cristaloleg
reviewed
Sep 20, 2024
| @@ -105,11 +104,13 @@ func TestDaModule(t *testing.T) { | |||
| { | |||
| name: "GetIDs", | |||
| doFn: func(t *testing.T) { | |||
| t.Skip() | |||
There was a problem hiding this comment.
I'm curious why it was skipped before. Anyone knows?
There was a problem hiding this comment.
IIRC order of returned IDs was non-deterministic in the past.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3743