Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification instructions. Closes #1300 #1301

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Add verification instructions. Closes #1300 #1301

merged 1 commit into from
Jun 21, 2023

Conversation

ZeroAurora
Copy link
Contributor

Description

Add verification instructions to the session list.

Screenshot:

图片

Fixes #1300

Also noticing that there are style and lint warnings in other files, I would like to remind maintainers about them :)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions
Copy link

github-actions bot commented Jun 20, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ZeroAurora
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Jun 20, 2023
@github-actions
Copy link

github-actions bot commented Jun 20, 2023

Preview: https://1301--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ZeroAurora
Copy link
Contributor Author

@kfiven resolved

Copy link
Collaborator

@kfiven kfiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR 🎊

@kfiven kfiven merged commit 4c84673 into cinnyapp:dev Jun 21, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt user the other way of verification when verifying in one side
2 participants