Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion from new ModuleDef -> existing TableSchema #1628

Open
kazimuth opened this issue Aug 23, 2024 · 0 comments
Open

Conversion from new ModuleDef -> existing TableSchema #1628

kazimuth opened this issue Aug 23, 2024 · 0 comments
Assignees
@kazimuth

Comments

@kazimuth
Copy link
Contributor

This will allow using the new ModuleDef validation code wherever we ingest RawModuleDefs and convert them to TableSchema etc in the codebase.

Requires an integration test that the following paths:

old: RawModuleDefV8 -> Vec<TableSchema>
new: RawModuleDefV8 -> RawModuleDefV9 -> ModuleDef -> Result<Vec<TableSchema>>

produce equivalent output (identical results, unless the new path rejects something that the old path accepts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazimuth kazimuth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kazimuth