Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlgebraicTypeDef and AlgebraicTypeUse #1651

Open
kazimuth opened this issue Aug 29, 2024 · 0 comments
Open

Add AlgebraicTypeDef and AlgebraicTypeUse #1651

kazimuth opened this issue Aug 29, 2024 · 0 comments
Assignees

Comments

@kazimuth
Copy link
Contributor

kazimuth commented Aug 29, 2024

We want to have methods that operate on AlgebraicTypes that have been validated as type definitions / type uses for client codegen. Currently the relevant methods (AlgebraicType::is_valid_for_client_type_def / AlgebraicType::is_valid_for_client_type_use) return bool, but they should be upgraded / have new methods added that return enums AlgebraicTypeDef / AlgebraicTypeUse storing precisely the information we want. (Parse, don't validate).

That is, UNLESS we want a deeper reworking of the type system to actually bake notions of separate "structural" and "nominal" types into the type system, or some other approach, cc @cloutiertyler. But this approach is easy to implement and will suffice for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant