Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter compression for transaction updates #1716

Open
joshua-spacetime opened this issue Sep 17, 2024 · 4 comments
Open

Smarter compression for transaction updates #1716

joshua-spacetime opened this issue Sep 17, 2024 · 4 comments
Assignees

Comments

@joshua-spacetime
Copy link
Collaborator

Currently message compression happens on a per-client basis. However typically many clients will subscribe to the same queries in which case we compress the same message multiple times. Note this compression happens off of the main execution thread. Depending on the implementation, removing such redundant compression may or may not require a breaking change to the API.

Note: I'm not proposing we do this. We should determine if it's worthwhile first.

@cloutiertyler
Copy link
Contributor

@Centril Can you determine if this would require a breaking change?

@gefjon
Copy link
Contributor

gefjon commented Sep 18, 2024

WS protocol versioning should protect us.

@cloutiertyler
Copy link
Contributor

Except for the fact that we'd have to support two versions right off the bat, which I would like to avoid.

@gefjon
Copy link
Contributor

gefjon commented Sep 18, 2024

True, if we want to do this in the near future it is more relevant whether it requires a different WS message schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants