Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/zmap/zcrypto #1284

Open
begemot63 opened this issue Apr 19, 2023 · 4 comments
Open

github.com/zmap/zcrypto #1284

begemot63 opened this issue Apr 19, 2023 · 4 comments

Comments

@begemot63
Copy link

Hello,
cloudflare/cfssl has direct dependency from github.com/zmap/zcrypto. The package becomes our service 4th dependency.
The github.com/zmap/zcrypto Readme file specifies :
"ZCrypto is a research library, designed to be used for data collection and analysis, as well as experimenting and prototyping. It should not be used to provide security for production systems."
We cannot use in production package which is marked by developer as dangerous and experimental .
The is possible to exclude github.com/zmap/zcrypto from dependency ? Could it be optional and driven by configuration?

@beauhoyt
Copy link

beauhoyt commented Jun 9, 2023

https://github.com/cloudflare/cfssl/blob/master/signer/local/local.go#L173

Doing a quick search through the code shows it's only used in one place and it's only used for linting.

@begemot63
Copy link
Author

begemot63 commented Jun 9, 2023 via email

@nickysemenza
Copy link
Member

zcrypto is required because it's needed for zlint, which is a very popular tool used by practically every CA: https://github.com/zmap/zlint#zlint-usersintegrations - in other words I don't think that notice should be taken at face value - https://github.com/search?q=repo%3Aletsencrypt%2Fboulder%20zcrypto&type=code here's example of Let's Encrypt importing zcrypto - I think you could gather some other good evidence to prove this library's usecase to your security team :)

@begemot63
Copy link
Author

begemot63 commented Jun 29, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants