Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] allow badges for cards #813

Open
caniszczyk opened this issue Mar 9, 2022 · 11 comments
Open

[FEATURE] allow badges for cards #813

caniszczyk opened this issue Mar 9, 2022 · 11 comments

Comments

@caniszczyk
Copy link

If you have a card on the landscape, like a project, would be cool to link to it in badge form from say a GitHub README :)

@AndreyKozlov1984
Copy link
Contributor

I try to realise what exactly you want, but it is really hard.

Do you mean there should be , I don't know, png image which you can insert into a README so it will look like "ReactJS" and then it will open a "....?selected=reactjs" ?

@AndreyKozlov1984
Copy link
Contributor

A badge like "100% passed" which we see a lot on a github page? I.e. a nice image with a link?

image

@caniszczyk
Copy link
Author

caniszczyk commented Mar 9, 2022 via email

@AndreyKozlov1984
Copy link
Contributor

Should I start from generating a png image? Also could you embed an example here with a gitpod?

@caniszczyk
Copy link
Author

caniszczyk commented Mar 14, 2022 via email

@AndreyKozlov1984
Copy link
Contributor

Ok, so my idea is to take this image:
image
And add a landscape logo at start and make it like "(Landscape Logo) Cloud Native Landscape | ItemName", so in fact I am just adding a fancy svg image which is later used as a link to the individual item.

I'll add a demo link from the landscapeapp README itself to show how it works!

@caniszczyk
Copy link
Author

caniszczyk commented Mar 14, 2022 via email

@AndreyKozlov1984
Copy link
Contributor

Agree! This means just a single svg file, and anyone can make a link to their item on a cncf landscape with this svg image to display the link itself.

@AndreyKozlov1984
Copy link
Contributor

@caniszczyk please review!

94db2ea?short_path=b335630#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

An example pull request with a badge in a README.md of a landscapeapp itself.

image

I just added a file images/link.svg to the cncf landscape repo and made it more or less looking ok as an svg image.

@AndreyKozlov1984
Copy link
Contributor

@caniszczyk What should we do with this issue? You can see this example works well.

@caniszczyk
Copy link
Author

I love it, can you update the document to include how to do this in the README.md? then we can we close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants