For some reason, the arrow keys don't advance/go back in time nor Up/Lower the Volume. Arrow keys just not working. #2406

Romdara13 · 2024-06-22T22:12:49Z

Bug Report: When i press either of the arrow keys, it doesn't advance/go back 5 seconds and does not Change the volume, it just freezes the video a bit without ANY change.

Description: upon clicking Arrow keys, nothing happens other than a little freeze in the player, then the video resumes and nothing happened. Note that the "L" and "J" Shortcuts for 10 seconds, odly, still work. Trying to mute the video with "M" also does not work. Another weird thing is that if i Change the Keys for "Seek Back/Foward 10 seconds" in the Shortcuts section, it stops working, its strictly something Arrows related.
Steps to reproduce this: I don't recall any changes in the config to reproduce the problem.
Since when?: It happened randomly after some hours that i downloaded the extension.
Browser: Firefox-
Are any errors shown in the Browser-Console?: (F12-key, then console-tab)
Does the bug not happen when you log out of YouTube? Then please copy your experiment flags list twice (with & without the error to compare). Enter: yt.config_.EXPERIMENT_FLAGS into the Browser console on youtube (F12-Key - Or find it in the html source(ctrl+U)

please check, if the issue has already been reported ever. (If so, that might inspires you to add different/better words to that report.)

GitHub's issue search (use the link or remove "is:issue is:open" from the search)

Expected preferred behavior:
ImprovedTube Version (Written in the Extension header & your Browser's store)
Tested as only active extension or in incognito mode?:
Your Settings (From the Extension's ⋮-Hamburger menu > Settings > Backup & reset > Export settings (You can remove any Blocklist, History Analyzer data - or paste the following in the Browser-Console and hit enter: (function({analyzer, blocklist, ...a}){return JSON.stringify(a)})(ImprovedTube.storage) )
YouTube-Document: (F12 copy the whole root element: <html> (alternative: CTRL+U) (https://github.com/code-charity/youtube/wiki/Contributing#Test )
OS / Device:

The text was updated successfully, but these errors were encountered:

raszpl · 2024-06-23T02:50:55Z

Current Shortcuts code has limitations #2312 but afaik we dont touch arrow keys at all. Are you sure you dont have another extension doing something with keyboard input actuve?

dante987 · 2024-06-23T06:32:15Z

hehe, I reported the same bug 10 hours ago even though the problem has been going on for a few days.

Unlike yours, mine is working totally fine on Firefox. I am facing these problems on "Opera One (version: 111.0.5168.25) - Chromium version:125.0.6422.143".
Extension Version 4.944

Even F5 to refresh the page is not working, so its not a YouTube problem.
Is your F5 working when on YouTube and this extension enabled ?

raszpl · 2024-06-23T11:52:39Z

Thats great! erm I mean for finding the bug :-) We can try to pinpoint source of the problem if you or Romdara13 are ready for some debugging.

wait until bug starts to happen
open Devtools - if F12 doesnt work use menu "Developer Mode" button (no idea how its called precisely in Opera One).
navigate to Sources / Page
find and click on 'Improve YouTube!' 🎧 (for YouTube & Videos)/js&css/web-accessible/www.youtube.com/shortcuts.js
scroll to line ~90 to if (handler() === true) {
put breakpoint (by clicking on line number, a blue marker shoudl appear) on the very next line event.preventDefault();
switch back to YT and try pressing button that no longer worked just a moment before

if breakpoint triggers then we (or your settings) are to blame :-)

dante987 · 2024-06-24T09:53:38Z

ok I did that.
As soon as I pressed M to Mute/Unmute on YouTube, it showed "Paused on breakpoint".

raszpl · 2024-06-24T15:31:59Z

put breakpoint (by clicking on line number, a blue marker shoudl appear) on the very next line event.preventDefault();

we are testing here if ImproveTube somehow wants to preventDefault() on keys that dont belong to it

dante987 · 2024-06-26T07:07:13Z

Did I do it right ? Is that what you wanted to check ?
I clicked on Line no.91, a blue arrow type thing(marker) appeared next to "if".
Then I went to youtube, clicked on the play button, then as soon as I pressed M to mute, it showed "ⓘ Paused on breakpoint" on the top right.
This is what you asked right ?

raszpl · 2024-06-26T11:52:23Z

on the very next line event.preventDefault();

dante987 · 2024-06-27T08:24:05Z

ok.
same thing occurred.
"Paused on breakpoint" on the top right
and
"Paused in debugger" over the Youtube video on the Left.

raszpl · 2024-06-27T12:44:54Z

ok, so its in your settings somehow
on youtube open devtools, console, paste (function({analyzer, blocklist, ...a}){return JSON.stringify(a)})(ImprovedTube.storage), copy result and post here

dante987 · 2024-06-27T19:55:39Z

ok, so its in your settings somehow on youtube open devtools, console, paste (function({analyzer, blocklist, ...a}){return JSON.stringify(a)})(ImprovedTube.storage), copy result and post here

'{"always_show_progress_bar":true,"ambient_lighting":false,"below_player_loop":true,"below_player_pip":false,"below_player_screenshot":false,"bluelight":0,"dim":0,"ga":1668341473944,"hide_gradient_bottom":true,"lastDarkTheme":"black","limit_page_width":true,"mark_watched_videos":false,"player_hd_thumbnail":false,"player_hide_cards":false,"player_loudness_normalization":false,"player_remaining_duration":true,"player_rotate_button":true,"player_screenshot_button":false,"player_screenshot_save_as":"clipboard","schedule":"disabled","shortcut_rotate_video":{},"shortcut_screenshot":{"alt":false,"ctrl":false,"keys":{"83":{"code":"KeyS","key":"S"}},"shift":true,"wheel":0},"theme":"black","theme_primary_color":[200,200,200],"theme_text_color":[25,25,25],"track_watched_videos":false,"up_next_autoplay":false,"youtube_language":"default"}'

raszpl · 2024-06-27T21:28:58Z

So this was the first time I read

youtube/js&css/web-accessible/www.youtube.com/shortcuts.js

Lines 18 to 72 in e1c339d

    
           function handler() { 
        
           	var prevent = false; 
        
           	for (var key in storage) { 
        
           		var shortcut = storage[key], 
        
           			same_keys = true; 
        
           		if ( 
        
           			typeof shortcut === 'object' && 
        
           			(keyboard.alt === shortcut.alt || !ImprovedTube.isset(shortcut.alt)) && 
        
           			(keyboard.ctrl === shortcut.ctrl || !ImprovedTube.isset(shortcut.ctrl)) && 
        
           			(keyboard.shift === shortcut.shift || !ImprovedTube.isset(shortcut.shift)) && 
        
           			(mouse.wheel === shortcut.wheel || !ImprovedTube.isset(shortcut.wheel)) 
        
           		) { 
        
           			if (keyboard.keys && shortcut.keys) { 
        
           				for (var code in keyboard.keys) { 
        
           					if (!shortcut.keys[code]) { 
        
           						same_keys = false; 
        
           					} 
        
           				} 
        
           				for (var code in shortcut.keys) { 
        
           					if (!keyboard.keys[code]) { 
        
           						same_keys = false; 
        
           					} 
        
           				} 
        
           			} 
        
           			if (!ImprovedTube.isset(mouse.wheel) || mouse.wheel === 0 || mouse.player === true) { 
        
           				if (same_keys === true) { 
        
           					if ([ 
        
           							'shortcutAuto', 
        
           							'shortcut144p', 
        
           							'shortcut240p', 
        
           							'shortcut360p', 
        
           							'shortcut480p', 
        
           							'shortcut720p', 
        
           							'shortcut1080p', 
        
           							'shortcut1440p', 
        
           							'shortcut2160p', 
        
           							'shortcut2880p', 
        
           							'shortcut4320p' 
        
           						].includes(key) === true) { 
        
           						ImprovedTube['shortcutQuality'](key); 
        
           					} else if (typeof ImprovedTube[key] === 'function') { 
        
           						ImprovedTube[key](); 
        
           					} 
        
           					prevent = true; 
        
           				} 
        
           			} 
        
           		} 
        
           	} 
        
           	return prevent; 
        
           }

its written in a weird way, it only actually compares keys if they exist, if a shortcut doesnt exist like yours "shortcut_rotate_video":{} it bugs out. It needs a rewrite. Why does it even allow empty shortcuts :

youtube/js&css/web-accessible/www.youtube.com/shortcuts.js

Line 165 in e1c339d

if (this.isset(this.storage[name]) && this.storage[name] !== false) {

funny thing about {} empty Objects in javascript, they are not null https://mortoray.com/the-many-faces-of-undefined-in-javascript/ its a true minefield https://x.com/BrendanEich/status/1273250867823538176

For a quickfix execute ImprovedTube.messages.send({action: 'set', key: 'shortcut_rotate_video', value: null}) in the console on YT page.

Boy Im glad I added that action: 'set' message few weeks ago :]

dante987 · 2024-06-28T07:51:15Z

For a quickfix execute ImprovedTube.messages.send({action: 'set', key: 'shortcut_rotate_video', value: null}) in the console on YT page.

yup, that fixed it.
Thank you :)

Romdara13 · 2024-07-01T20:29:19Z

I kinda forgor about this problem and all 💀, ill try using the fix now, Thank you! Em seg., 1 de jul. de 2024, 16:01, Rasz_pl ***@***.***> escreveu:

…

Closed #2406 <#2406> as completed. — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BJMJBUJZXW2EAO5JCL5SNNLZKGRQJAVCNFSM6AAAAABJXYOW72VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGM2TKNBRGAZDINI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

raszpl · 2024-07-01T20:53:42Z

quickfix was tailored specifically for dante987 config
Romdara13 you will have to either manually find all broken shortcut_ definitions or
note down which ones you use
in Improvetube popup paste "Reset all shortcuts" inside search bar and click it to reset all shortcuts
configure your shortcuts again

or wait for next update :)

dante987 mentioned this issue Jun 28, 2024

Default Youtube player shortcuts disabled on Opera browser. #2403

Closed

raszpl closed this as completed Jul 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For some reason, the arrow keys don't advance/go back in time nor Up/Lower the Volume. Arrow keys just not working. #2406

For some reason, the arrow keys don't advance/go back in time nor Up/Lower the Volume. Arrow keys just not working. #2406

Romdara13 commented Jun 22, 2024

raszpl commented Jun 23, 2024

dante987 commented Jun 23, 2024 •

edited

Loading

raszpl commented Jun 23, 2024

dante987 commented Jun 24, 2024

raszpl commented Jun 24, 2024 •

edited

Loading

dante987 commented Jun 26, 2024

raszpl commented Jun 26, 2024

on the very next line event.preventDefault();

dante987 commented Jun 27, 2024

raszpl commented Jun 27, 2024

dante987 commented Jun 27, 2024

raszpl commented Jun 27, 2024 •

edited

Loading

dante987 commented Jun 28, 2024

Romdara13 commented Jul 1, 2024 via email

raszpl commented Jul 1, 2024

For some reason, the arrow keys don't advance/go back in time nor Up/Lower the Volume. Arrow keys just not working. #2406

For some reason, the arrow keys don't advance/go back in time nor Up/Lower the Volume. Arrow keys just not working. #2406

Comments

Romdara13 commented Jun 22, 2024

Bug Report: When i press either of the arrow keys, it doesn't advance/go back 5 seconds and does not Change the volume, it just freezes the video a bit without ANY change.

raszpl commented Jun 23, 2024

dante987 commented Jun 23, 2024 • edited Loading

raszpl commented Jun 23, 2024

dante987 commented Jun 24, 2024

raszpl commented Jun 24, 2024 • edited Loading

dante987 commented Jun 26, 2024

raszpl commented Jun 26, 2024

on the very next line event.preventDefault();

dante987 commented Jun 27, 2024

raszpl commented Jun 27, 2024

dante987 commented Jun 27, 2024

raszpl commented Jun 27, 2024 • edited Loading

dante987 commented Jun 28, 2024

Romdara13 commented Jul 1, 2024 via email

raszpl commented Jul 1, 2024

dante987 commented Jun 23, 2024 •

edited

Loading

raszpl commented Jun 24, 2024 •

edited

Loading

raszpl commented Jun 27, 2024 •

edited

Loading