Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞Appearance - Custom progress bar color broken in new UI #2567

Open
Guildes opened this issue Sep 13, 2024 · 1 comment
Open

🐞Appearance - Custom progress bar color broken in new UI #2567

Guildes opened this issue Sep 13, 2024 · 1 comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Guildes
Copy link

Guildes commented Sep 13, 2024

Concise Description

There's a new youtube UI change in AB testing that is account-based and my account got selected for it with no way to turn it off, it adds a new style for the progress bar that has a red to magenta gradient instead of a solid color and it overrides the extension's custom color with the exception of the seeker dot
image
Also applies to watched videos' thumbnails
image

Browser/s

Opera GX

Other Browser:

No response

'Steps to reproduce' - Which of our features is required for the bug to happen?

Get an account with the flag enabled and change progress bar color with the extension

Since when?

~July 2024

Does the bug still happen when you log out of YouTube?

No

..No? Then please paste your yt.config_.EXPERIMENT_FLAGS. Twice (With the error & Without)

Logged-in Flags.txt
Logged-out Flags.txt

Are any errors or related log-messages shown in the Browser-Console? (F12)

No response

Tested as the only active extension? (incognito mode or another browser users):

Yes

Expected preferred behavior:

Progress bar color to change

ImprovedTube Version

Chrome Web Store - 4.1094

Your Settings (From the Extension's -Hamburger menu > Settings > Backup & reset > Export settings)

No response

Your YouTube-Document

No response

OS / Device:

Windows 10

@Guildes Guildes added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Sep 13, 2024
@ImprovedTube
Copy link
Member

hi and thanks! @Guildes So we can easily set this with one of Youtube's new Experiments, which you get only when logged in.
To try, you can Invert some in uBlock Origin's "my filters":

youtube.com##+js(set, enable_cairo_refresh_web, false)
youtube.com##+js(set, enable_cairo_refresh_signature_moments_web, false)
youtube.com##+js(set, enable_cairo_refresh_ringo2_web, false)
youtube.com##+js(set, ab_det_apb_b, false)
youtube.com##+js(set, kevlar_poly_si_batch_j020, true)

and if it helps, narrow down which one exactly?


#2251 (adding 66 from your lists, we now know 1125 of these now)

It will be efficient if some people will help to name / explain them in the spreadsheet. And a developer will continue the code.

ImprovedTube.YouTubeExperiments = function () {
if ((this.storage.undo_the_new_sidebar === "true" || this.storage.description === "sidebar")
&& document.documentElement.dataset.pageType === 'video') {
if (window.yt?.config_?.EXPERIMENT_FLAGS) {
const newSidebarFlags = [
'kevlar_watch_grid',
'small_avatars_for_comments',
'small_avatars_for_comments_ep',
'web_watch_rounded_player_large'
];
if (this.storage.undo_the_new_sidebar === "true") {
if (window.yt.config_.EXPERIMENT_FLAGS.kevlar_watch_grid !== false) {
try {
newSidebarFlags.forEach(F => {
Object.defineProperty(window.yt.config_.EXPERIMENT_FLAGS, F, { get: () => false });
});
} catch (error) { console.error("can't undo description on the side", error); }
}} else if (this.storage.description === "sidebar" && window.yt.config_.EXPERIMENT_FLAGS.kevlar_watch_grid !== true) {
try {
newSidebarFlags.forEach(F => {
Object.defineProperty(window.yt.config_.EXPERIMENT_FLAGS, F, { get: () => true });
});
} catch (error) { console.error("tried to move description to the sidebar", error); }
}
} else { console.log ("yt.config_.EXPERIMENT_FLAGS is not yet defined") }
}
}
/*try {
yt.config_.EXPERIMENT_FLAGS.kevlar_watch_grid = false;
yt.config_.EXPERIMENT_FLAGS.small_avatars_for_comments = false;
yt.config_.EXPERIMENT_FLAGS.small_avatars_for_comments_ep = false;
yt.config_.EXPERIMENT_FLAGS.web_watch_rounded_player_large = false;
} catch (error) { console.error("can't undo description on the side", error); }
try {
yt.config_.EXPERIMENT_FLAGS.kevlar_watch_grid = true;
yt.config_.EXPERIMENT_FLAGS.small_avatars_for_comments = true;
yt.config_.EXPERIMENT_FLAGS.small_avatars_for_comments_ep = true;
} catch (error) { console.error("tried to move description to the sidebar", error); }
*/
/*------------------------------------------------------------------------------

(Considering this single feature, we probably also can add some CSS to cover the new, the old and experiments
However you could set each of Youtube's experiment flags with the same code.
So it can be on top of this ImprovedTube's To-Do list)


Logged-in Flags.txt
Logged-out Flags.txt

Only when logged in:

flag value
web_home_appeal_survey TRUE
web_enable_constrained_list_subscriptions_channels TRUE
use_rta_manager_for_async TRUE
PremiumClientSharedConfig__enable_att_for_get_premium_on_web_client TRUE
PremiumClientSharedConfig__enable_att_context_processor TRUE
mweb_c3_remove_web_navigation_endpoint_data TRUE
kevlar_cache_cold_load_response TRUE
enable_profile_cards_on_comments TRUE
enable_cairo_refresh_web TRUE
enable_cairo_refresh_signature_moments_web TRUE
enable_cairo_refresh_ringo2_web TRUE
ab_det_apb_b TRUE

Only when logged out:

flag value
web_modern_vwt_surveys_v2 TRUE
web_modern_vwt_surveys_sampled_unclickable_video TRUE
web_modern_vwt_surveys_sampled TRUE
web_modern_vwt_surveys TRUE
web_modern_surveys TRUE
web_ad_card_buttoned_clickable TRUE
mweb_use_server_url_on_startup TRUE
kevlar_poly_si_batch_j020 TRUE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

2 participants