Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Return YouTube Dislike #2570

Open
CsatiZoltan opened this issue Sep 16, 2024 · 4 comments
Open

Incompatibility with Return YouTube Dislike #2570

CsatiZoltan opened this issue Sep 16, 2024 · 4 comments
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@CsatiZoltan
Copy link

Bug Report:

  • Description: The Return YouTube Dislike extension (https://github.com/Anarios/return-youtube-dislike) shows the like and dislike count, and also their ratio in a bar, as seen below.
    without_improve_youtube
    When I also install the Improve YouTube extension, the bar no longer indicates the ratio (the like and dislike count works, but the ratio bar does not):
    with_improve_youtube

  • Steps to reproduce this: (Might only happen with a certain feature of our's enabled?) Tested on the following video, but the issue is not linked to a specific video: https://www.youtube.com/watch?v=S7znI_Kpzbs. Install both your extension and the Return YouTube Dislike extension to reproduce the bug.

  • Since when?: Was always like this.

  • Browser: Firefox 130.0

  • Are any errors shown in the Browser-Console?: (F12-key, then console-tab) Yes, there are. But i) errors appear even without this extension, ii) I cannot interpret what they mean. So I exported the log, with Improve YouTube enabled and disabled:
    without_improve_youtube.txt
    with_improve_youtube.txt

  • Does the bug not happen when you log out of YouTube? Then please copy your experiment flags list twice (with & without the error to compare). Enter: yt.config_.EXPERIMENT_FLAGS into the Browser console on youtube (F12-Key - Or find it in the html source(ctrl+U) . Indifferent whether logged in or out. Here are the flags with Improve YouTube enabled and disabled:
    experiment_flags_without_improveYT.txt
    experiment_flags_with_improveYT.txt

please check, if the issue has already been reported ever. (If so, that might inspires you to add different/better words to that report.)

GitHub's issue search (use the link or remove "is:issue is:open" from the search)

  • Expected preferred behavior: I would like both extensions work correctly.

  • ImprovedTube Version (Written in the Extension header & your Browser's store): 4.096

  • Tested as only active extension or in incognito mode?: Yes, same behaviour.

  • Your Settings (From the Extension's -Hamburger menu > Settings > Backup & reset > Export settings (You can remove any Blocklist, History Analyzer data - or paste the following in the Browser-Console and hit enter: (function({analyzer, blocklist, ...a}){return JSON.stringify(a)})(ImprovedTube.storage) ): Here it is: settings.json

  • YouTube-Document: (F12 copy the whole root element: <html> (alternative: CTRL+U) (https://github.com/code-charity/youtube/wiki/Contributing#Test ) Here is the page source: page_source.txt

  • OS / Device: Linux pop-os 6.9.3-76060903-generic #202405300957~1721174657~22.04~abb7c06 SMP PREEMPT_DYNAMIC Wed J x86_64 x86_64 x86_64 GNU/Linux

@CsatiZoltan CsatiZoltan added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Sep 16, 2024
@ImprovedTube
Copy link
Member

hi! @CsatiZoltan thank you for caring!


interesting if it depends on one of youtube's experiment flags too! :

#2251

@CsatiZoltan
Copy link
Author

@ImprovedTube What do you mean? What action do you expect from me?

@ImprovedTube
Copy link
Member

Does the bug not happen when you log out of YouTube? Then please copy your experiment flags list twice (with & without the error to compare). Enter: yt.config_.EXPERIMENT_FLAGS into the Browser console on youtube (F12-Key - Or find it in the html source(ctrl+U) . Indifferent whether logged in or out. Here are the flags with Improve YouTube enabled and disabled:
experiment_flags_without_improveYT.txt
experiment_flags_with_improveYT.txt

i'm looking forward to add your experiment flags to our complete list! (Even if it doesn't relate to this issue #2570 as i see now. The list changes a bit only when logging out of Youtube. So your two are the same.)

@CsatiZoltan
Copy link
Author

@ImprovedTube Reading Anarios/return-youtube-dislike#875: unfortunately, I cannot help as I have no web development experience. All I can do is filing as complete bug report as possible (and I think I filled in all the entries in the bug report template of this issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

2 participants