Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename envbuilder.MagicDir to envbuilder.WorkingDir #184

Open
johnstcn opened this issue May 13, 2024 · 0 comments
Open

rename envbuilder.MagicDir to envbuilder.WorkingDir #184

johnstcn opened this issue May 13, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@johnstcn
Copy link
Member 

          Not introduced by your PR but I want to point out that `MagicDir` is kinda unhelpful as a name; perhaps `EnvbuilderWorkingDir` would be more explicit?

Originally posted by @dannykopping in #183 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mafredri @johnstcn