Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: replace agentsdk.LogSender direct integration with external log sender #193

Open
johnstcn opened this issue May 16, 2024 · 1 comment
Labels
enhancement New feature or request spike Investigation to prove feasibility or validate an idea

Comments

@johnstcn
Copy link
Member

johnstcn commented May 16, 2024

Currently, envbuilder consumes CODER_AGENT_URL, CODER_AGENT_TOKEN, and CODER_AGENT_SUBSYSTEM environment variables to enable sending workspace build logs to Coder.

For Kubernetes, this can instead be handled by coder/coder-logstream-kube.
Investigate an alternative approach for envbuilder usage outside of Kubernetes (e.g. Docker).

This is also kind important because envbuilder currently references on agentsdk.ExternalLogSourceID which is marked for use by 'legacy API consumers'.

@johnstcn johnstcn added enhancement New feature or request spike Investigation to prove feasibility or validate an idea labels May 16, 2024
@johnstcn johnstcn changed the title remove tight coupling with coder/coder enhancement: replace agentsdk.LogSender direct integration with external log sender May 16, 2024
@johnstcn
Copy link
Member Author

One possibility is a custom logging driver https://docs.docker.com/engine/extend/plugins_logging/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spike Investigation to prove feasibility or validate an idea
Projects
None yet
Development

No branches or pull requests

1 participant