Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liquid-dsp: migrate to Conan v2 #18866

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 24, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Hooks produced the following warnings for commit 48563f1
liquid-dsp/1.6.0@#feb4d99c249be296e0ed133042efef6c
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libliquid.dylib
liquid-dsp/1.3.2@#57aabc0acb8fb64c184458a6746b901b
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libliquid.dylib

Copy link
Contributor

github-actions bot commented Aug 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 4, 2024
@valgur
Copy link
Contributor Author

valgur commented Aug 4, 2024

not stale

@github-actions github-actions bot removed the stale label Aug 5, 2024
@perseoGI perseoGI self-assigned this Aug 5, 2024
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but need answers for the decision of removing windows support

recipes/liquid-dsp/all/conanfile.py Outdated Show resolved Hide resolved
raise ConanInvalidConfiguration("Cross building is not yet supported. Contributions are welcome")
if is_msvc(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Conan 1 this recipe supports Windows, why are we removing support in this migration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did so only through fetching MinGW via Conan and building with it instead of MSVC. I did try that approach and got it to work locally, but it kept failing on C3I due to a missing DLL despite at least 10 iterations of trying to fix this (and Windows is very unhelpful with its DLL error messages).
Relying on GCC from MinGW is a bit of a fragile edge-case for Conan, since it also becomes a build/runtime dependency unless you link GCC statically into a shared library. It's not well supported. See also #21193 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, we will leave this for the future then. It is better to have this recipe working in conan v2 for now. Even if it does not support MSVC

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 19, 2024
@valgur
Copy link
Contributor Author

valgur commented Sep 19, 2024

don't close

@github-actions github-actions bot removed the stale label Sep 20, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (f3af01b1a4c5b75d4cb98e520a4b2d749abc6dfe):

  • liquid-dsp/1.3.2:
    Built 16 packages out of 22 (All logs)

  • liquid-dsp/1.6.0:
    Built 16 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (f3af01b1a4c5b75d4cb98e520a4b2d749abc6dfe):

  • liquid-dsp/1.6.0:
    Built 4 packages out of 10 (All logs)

  • liquid-dsp/1.3.2:
    Built 4 packages out of 10 (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit f3af01b
liquid-dsp/1.3.2@#66e83a981bb7bfcdbd20d23273935fc1
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libliquid.dylib
liquid-dsp/1.6.0@#5ccd1f0ba8f6a9303a657be82b58564d
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libliquid.dylib

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants