diligent-core: fix android compilation and several warnings #25340
+44
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: diligent-core/all
Motivation
This recipe could not be compiled in Android due to upstream CMakeLists.txt only installs core
includes
in Apple, Linux and Windows.Closes #9796
Details
This PR forces upstream CMakeLists.txt to always install core includes and fixes warnings catch by
conan lint
Android compilation traces:
Android test_package emulation
$ emu64a:/data/local/tmp $ ls -l total 740 -rwxrwxrwx 1 shell shell 750776 2024-09-20 12:47 test_package $ emu64a:/data/local/tmp $ file test_package test_package: ELF shared object, 64-bit LSB arm64, dynamic (/system/bin/linker64), for Android 24, built by NDK r26d (11579264), BuildID=698a826d1be7fe91cd7b3a0f35476a681b08ad73, not stripped $ emu64a:/data/local/tmp $ ./test_package PLATFORM_ANDROID: 1