-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openblas: add v0.3.28, drop old versions and patches, add OpenMP and ILP64 support #25344
base: master
Are you sure you want to change the base?
Conversation
/cc @samuel-emrys since you seem to be interested in BLAS and LAPACK support on CCI. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Summary
Changes to recipe: openblas/[*]
Motivation
The current recipe is missing options for a few core features like OpenMP, ILP64 and the max number of available threads.
This limits its usefulness in libraries like faiss (#25272), Ginkgo (PR coming soon) and any other library that significantly relies on BLAS for linear algebra performance.
Details
Adds latest v0.3.28 and drops all versions v0.3.20 and older, which gets rid of many patches and checks.
Also adds support for all major options in the build system: https://github.com/OpenMathLib/OpenBLAS/blob/develop/docs/build_system.md#important-variables
Fixed the exporting of serial/pthread/openmp component.
The value of 128 for the max number of threads was picked based on the value used by Debian and the current upper limit of available cores on consumer-grade hardware. Spack uses a value of 512, for example, but they also mostly target supercomputers.