Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin seems to add a ton of duplicate arguments #148

Open
etodanik opened this issue Aug 31, 2023 · 5 comments · Fixed by #155
Open

Plugin seems to add a ton of duplicate arguments #148

etodanik opened this issue Aug 31, 2023 · 5 comments · Fixed by #155
Assignees
Labels

Comments

@etodanik
Copy link

I end up getting stuff like:

-DBUILD_TESTING:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=OFF -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=C:\Users\danny\CLionProjects\elixir-overlay\conan_provider.cmake -DCONAN_COMMAND="C:\Program Files\Conan\conan\conan.exe" -DBUILD_INTEGRATION:BOOL=ON -DBUILD_WITH_MT:BOOL=ON -DCEF_RUNTIME_LIBRARY_FLAG:STRING=/MT -DUSE_SANDBOX:BOOL=OFF -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES="C:\Users\danny\CLionProjects\elixir-overlay\conan_provider.cmake"

With multiple conan_provider.cmake references.

@czoido czoido self-assigned this Aug 31, 2023
@czoido
Copy link
Contributor

czoido commented Aug 31, 2023

Hi @israelidanny,

Thanks a lot for reporting. I could not reproduce it so far. Could you please comment the steps you followed until that happens?

@etodanik
Copy link
Author

Hard to say. I can say for sure though that no matter how much I try to remove extra strings, the plug-in keeps adding and adding.

@czoido
Copy link
Contributor

czoido commented Aug 31, 2023

But do you know which action makes that the repeated CMAKE_PROJECT_TOP_LEVEL_INCLUDES is added? Maybe that way I could reproduce.
Does it happen for a new empty project from scratch as well?

@etodanik
Copy link
Author

etodanik commented Aug 31, 2023 via email

@etodanik
Copy link
Author

etodanik commented Sep 3, 2023

Also, one more observation- it seems to alternate between those two forms:

-DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=C:\Users\danny\CLionProjects\elixir-overlay\conan_provider.cmake
-DCMAKE_PROJECT_TOP_LEVEL_INCLUDES="C:\Users\danny\CLionProjects\elixir-overlay\conan_provider.cmake"

With or without double quotes.

@czoido czoido reopened this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants