Fix propagation of include_prerelease when calculating VersionRange intersection #16986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lordjaxom
force-pushed
the
lj/fix-include_prerelease-version-range
branch
from
64a158c
to
334a786
Compare
|
Hi @lordjaxom thanks a lot for taking the time to both submit the issue and open a PR to address it We want to take a closer look into the actual propagation logic, as there are a few things that I think need more thought, will keep you updated :) |
|
No problem, I suspected that my fix might be a bit naive. I submitted the PR because we need that fix anyway (thankfully it is possible to pip install from a GitHub repository) and for us, the simple solution suffices for now. |
AbrilRBS
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Propagate include_prerelease flag to intersection of VersionRange
fixes: #16983