Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uvicorn standard dependencies #2894

Closed
Andrew-Chen-Wang opened this issue Oct 12, 2020 · 4 comments
Closed

Uvicorn standard dependencies #2894

Andrew-Chen-Wang opened this issue Oct 12, 2020 · 4 comments

Comments

@Andrew-Chen-Wang
Copy link
Contributor

https://github.com/pydanny/cookiecutter-django/blob/6865ef39fd78fc1bf0ba7efb2b7d0b129d7a19e0/%7B%7Bcookiecutter.project_slug%7D%7D/requirements/base.txt#L27-L28

Ref: #2881

It might be best to do uvicorn[standard] rather than just uvicorn so that people get the benefit from "Cython-based" dependencies (where possible).

My only concern is that this change was pretty breaking, and I'm not sure if we should do an installation of uvicorn[standard] or simply list all dependencies (i.e.. just write httptools==blah and uvloop==blah etc.).
@foarsitter foarsitter mentioned this issue Oct 28, 2020
Closed
@Andrew-Chen-Wang
Copy link
Contributor Author

Should be fixed if I can get mypy to stop being bad in #2921

@browniebroke
Copy link
Member

I'm in favor of simplifying the list of dependencies to list on our end, and specify only uvicorn[standard].

@Andrew-Chen-Wang
Copy link
Contributor Author

Should be reflected in that pr now.

@browniebroke
Copy link
Member

Forgot about this one, it was fixed in #2939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@browniebroke @Andrew-Chen-Wang