From 60135141085bbd477a022ad2fc93b8ead0b698b5 Mon Sep 17 00:00:00 2001 From: DimitrisJim Date: Tue, 23 Apr 2024 14:52:25 +0300 Subject: [PATCH] remove pending TODOs --- modules/light-clients/08-wasm/depinject.go | 3 +-- modules/light-clients/08-wasm/testing/simapp/app.go | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/light-clients/08-wasm/depinject.go b/modules/light-clients/08-wasm/depinject.go index 23f4eaf9717..3706ce45401 100644 --- a/modules/light-clients/08-wasm/depinject.go +++ b/modules/light-clients/08-wasm/depinject.go @@ -4,7 +4,6 @@ import ( "cosmossdk.io/core/appmodule" "cosmossdk.io/core/store" "cosmossdk.io/depinject" - "github.com/cosmos/cosmos-sdk/codec" authtypes "github.com/cosmos/cosmos-sdk/x/auth/types" govtypes "github.com/cosmos/cosmos-sdk/x/gov/types" @@ -65,7 +64,7 @@ func ProvideModule(in ModuleInputs) ModuleOutputs { in.Cdc, in.StoreService, in.ClientKeeper, authority.String(), in.VM, in.QueryRouter, in.Opts..., ) } else { - // TODO(jim): Check that config is non-nil and panic? + // TODO(jim): If missing, its default value is used. This could very well be surprising and cause misconfiguration keeper = wasmkeeper.NewKeeperWithConfig( in.Cdc, in.StoreService, in.ClientKeeper, authority.String(), in.VMConfig, in.QueryRouter, in.Opts..., ) diff --git a/modules/light-clients/08-wasm/testing/simapp/app.go b/modules/light-clients/08-wasm/testing/simapp/app.go index 5a47de6f110..1efb693c8b8 100644 --- a/modules/light-clients/08-wasm/testing/simapp/app.go +++ b/modules/light-clients/08-wasm/testing/simapp/app.go @@ -662,7 +662,7 @@ func NewSimApp( mockModule, // IBC light clients - wasm.NewAppModule(wasmLightClientModule), // TODO(damian): see if we want to pass the lightclient module here, keeper is used in AppModule.RegisterServices etc + wasm.NewAppModule(wasmLightClientModule), ibctm.NewAppModule(tmLightClientModule), solomachine.NewAppModule(smLightClientModule), )