Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a WrapAcknowledgement function for backwards compatibility #7043

Closed
3 tasks
colin-axner opened this issue Aug 5, 2024 · 2 comments
Closed
3 tasks

Comments

@colin-axner
Copy link
Contributor

Summary

In 05-port router, we want to get away from middlewares wrapping acknoweledgements of applications below them. Core IBC will instead maintain a map from app name to the ack for that application. To maintain backwards compatibility, core IBC needs to be capable of setting the acknowledgement in the format the counterparty expects.

We may need a Unwrap function, but it might be possible to have relayers pass in the flat map.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan
Copy link
Member

damiannolan commented Aug 15, 2024

This issue is more or less solved in #7176, but we will hold off on cherry-picking out the code separately for this for the time being until we are happy with the overall direction for OnRecvPacket.

Core IBC will instead maintain a map from app name to the ack for that application.

This will be also relevant for forwards compatibility for multi packetdata / mutli acknowledgements.

@colin-axner
Copy link
Contributor Author

This issue is being closed as the team has decided to move in another direction #6941 (comment) - it will be reopened if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants